From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Sun, 23 May 2010 16:54:13 +0000 (+0000)
Subject: issue_warnings() has no business freeing its parameter, especially not when
X-Git-Tag: REL9_0_BETA2~81
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=add8044778a9f158eafb65b66fb1c0cd3f2c6718;p=postgresql

issue_warnings() has no business freeing its parameter, especially not when
its sole caller does that too.  Jan Matousek, via Pavel Stehule
---

diff --git a/contrib/pg_upgrade/check.c b/contrib/pg_upgrade/check.c
index 31f12fbab2..f989229f86 100644
--- a/contrib/pg_upgrade/check.c
+++ b/contrib/pg_upgrade/check.c
@@ -154,7 +154,6 @@ issue_warnings(migratorContext *ctx, char *sequence_script_file_name)
 					  ctx->new.bindir, ctx->new.port, sequence_script_file_name,
 					  ctx->logfile);
 			unlink(sequence_script_file_name);
-			pg_free(sequence_script_file_name);
 			check_ok(ctx);
 		}