From: Kevin McCarthy <kevin@8t8.us>
Date: Fri, 6 Sep 2019 23:14:08 +0000 (-0700)
Subject: Convert bcache to use buffer pools.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ad72ec6c4672149a21c9655299b5c769bd3cbf78;p=mutt

Convert bcache to use buffer pools.
---

diff --git a/bcache.c b/bcache.c
index 5530d0cf..0fef6c32 100644
--- a/bcache.c
+++ b/bcache.c
@@ -34,19 +34,16 @@
 #include "lib.h"
 
 struct body_cache {
-  char path[_POSIX_PATH_MAX];
-  size_t pathlen;
+  char *path;
 };
 
-static int bcache_path(ACCOUNT *account, const char *mailbox,
-		       char *dst, size_t dstlen)
+static int bcache_path(ACCOUNT *account, const char *mailbox, body_cache_t *bcache)
 {
   char host[STRING];
-  char path[_POSIX_PATH_MAX];
+  BUFFER *path, *dst;
   ciss_url_t url;
-  int len;
 
-  if (!account || !MessageCachedir || !dst || !dstlen)
+  if (!account || !MessageCachedir || !bcache)
     return -1;
 
   /* make up a ciss_url_t we can turn into a string */
@@ -63,19 +60,19 @@ static int bcache_path(ACCOUNT *account, const char *mailbox,
     return -1;
   }
 
-  mutt_encode_path (path, sizeof (path), NONULL (mailbox));
+  path = mutt_buffer_pool_get ();
+  dst = mutt_buffer_pool_get ();
+  mutt_buffer_encode_path (path, NONULL (mailbox));
 
-  len = snprintf (dst, dstlen-1, "%s/%s%s%s", MessageCachedir,
-		  host, path,
-		  (*path && path[mutt_strlen (path) - 1] == '/') ? "" : "/");
+  mutt_buffer_printf (dst, "%s/%s%s", MessageCachedir, host, mutt_b2s (path));
+  if (*(dst->dptr - 1) != '/')
+    mutt_buffer_addch (dst, '/');
 
-  dprint (3, (debugfile, "bcache_path: rc: %d, path: '%s'\n", len, dst));
-
-  if (len < 0 || (size_t)len >= dstlen-1)
-    return -1;
-
-  dprint (3, (debugfile, "bcache_path: directory: '%s'\n", dst));
+  dprint (3, (debugfile, "bcache_path: path: '%s'\n", mutt_b2s (dst)));
+  bcache->path = safe_strdup (mutt_b2s (dst));
 
+  mutt_buffer_pool_release (&path);
+  mutt_buffer_pool_release (&dst);
   return 0;
 }
 
@@ -87,16 +84,13 @@ body_cache_t *mutt_bcache_open (ACCOUNT *account, const char *mailbox)
     goto bail;
 
   bcache = safe_calloc (1, sizeof (struct body_cache));
-  if (bcache_path (account, mailbox, bcache->path,
-		   sizeof (bcache->path)) < 0)
+  if (bcache_path (account, mailbox, bcache) < 0)
     goto bail;
-  bcache->pathlen = mutt_strlen (bcache->path);
 
   return bcache;
 
 bail:
-  if (bcache)
-    FREE(&bcache);
+  mutt_bcache_close (&bcache);
   return NULL;
 }
 
@@ -104,126 +98,151 @@ void mutt_bcache_close (body_cache_t **bcache)
 {
   if (!bcache || !*bcache)
     return;
+  FREE (&(*bcache)->path);
   FREE(bcache);			/* __FREE_CHECKED__ */
 }
 
 FILE* mutt_bcache_get(body_cache_t *bcache, const char *id)
 {
-  char path[_POSIX_PATH_MAX];
+  BUFFER *path;
   FILE* fp = NULL;
 
   if (!id || !*id || !bcache)
     return NULL;
 
-  path[0] = '\0';
-  safe_strncat (path, sizeof (path), bcache->path, bcache->pathlen);
-  safe_strncat (path, sizeof (path), id, mutt_strlen (id));
+  path = mutt_buffer_pool_get ();
+  mutt_buffer_addstr (path, bcache->path);
+  mutt_buffer_addstr (path, id);
 
-  fp = safe_fopen (path, "r");
+  fp = safe_fopen (mutt_b2s (path), "r");
 
-  dprint (3, (debugfile, "bcache: get: '%s': %s\n", path, fp == NULL ? "no" : "yes"));
+  dprint (3, (debugfile, "bcache: get: '%s': %s\n", mutt_b2s (path),
+              fp == NULL ? "no" : "yes"));
 
+  mutt_buffer_pool_release (&path);
   return fp;
 }
 
 FILE* mutt_bcache_put(body_cache_t *bcache, const char *id, int tmp)
 {
-  char path[_POSIX_PATH_MAX];
-  FILE* fp;
-  char* s;
+  BUFFER *path = NULL;
+  FILE* fp = NULL;
+  char* s = NULL;
   struct stat sb;
 
   if (!id || !*id || !bcache)
     return NULL;
 
-  snprintf (path, sizeof (path), "%s%s%s", bcache->path, id,
-            tmp ? ".tmp" : "");
+  path = mutt_buffer_pool_get ();
+  mutt_buffer_printf (path, "%s%s%s", bcache->path, id,
+                      tmp ? ".tmp" : "");
 
-  if ((fp = safe_fopen (path, "w+")))
+  if ((fp = safe_fopen (mutt_b2s (path), "w+")))
     goto out;
 
   if (errno == EEXIST)
     /* clean up leftover tmp file */
-    mutt_unlink (path);
+    mutt_unlink (mutt_b2s (path));
 
-  s = strchr (path + 1, '/');
-  while (!(fp = safe_fopen (path, "w+")) && errno == ENOENT && s)
+  if (mutt_buffer_len (path))
+    s = strchr (path->data + 1, '/');
+  while (!(fp = safe_fopen (mutt_b2s (path), "w+")) && errno == ENOENT && s)
   {
     /* create missing path components */
     *s = '\0';
-    if (stat (path, &sb) < 0 && (errno != ENOENT || mkdir (path, 0777) < 0))
-      return NULL;
+    if (stat (mutt_b2s (path), &sb) < 0 &&
+        (errno != ENOENT || mkdir (mutt_b2s (path), 0777) < 0))
+      goto out;
     *s = '/';
     s = strchr (s + 1, '/');
   }
 
 out:
-  dprint (3, (debugfile, "bcache: put: '%s'\n", path));
-
+  dprint (3, (debugfile, "bcache: put: '%s'\n", mutt_b2s (path)));
+  mutt_buffer_pool_release (&path);
   return fp;
 }
 
 int mutt_bcache_commit(body_cache_t* bcache, const char* id)
 {
-  char tmpid[_POSIX_PATH_MAX];
+  BUFFER *tmpid;
+  int rv;
+
+  tmpid = mutt_buffer_pool_get ();
+  mutt_buffer_printf (tmpid, "%s.tmp", id);
 
-  snprintf (tmpid, sizeof (tmpid), "%s.tmp", id);
+  rv = mutt_bcache_move (bcache, mutt_b2s (tmpid), id);
 
-  return mutt_bcache_move (bcache, tmpid, id);
+  mutt_buffer_pool_release (&tmpid);
+  return rv;
 }
 
 int mutt_bcache_move(body_cache_t* bcache, const char* id, const char* newid)
 {
-  char path[_POSIX_PATH_MAX];
-  char newpath[_POSIX_PATH_MAX];
+  BUFFER *path, *newpath;
+  int rv;
 
   if (!bcache || !id || !*id || !newid || !*newid)
     return -1;
 
-  snprintf (path, sizeof (path), "%s%s", bcache->path, id);
-  snprintf (newpath, sizeof (newpath), "%s%s", bcache->path, newid);
+  path = mutt_buffer_pool_get ();
+  newpath = mutt_buffer_pool_get ();
+
+  mutt_buffer_printf (path, "%s%s", bcache->path, id);
+  mutt_buffer_printf (newpath, "%s%s", bcache->path, newid);
 
-  dprint (3, (debugfile, "bcache: mv: '%s' '%s'\n", path, newpath));
+  dprint (3, (debugfile, "bcache: mv: '%s' '%s'\n",
+              mutt_b2s (path), mutt_b2s (newpath)));
 
-  return rename (path, newpath);
+  rv = rename (mutt_b2s (path), mutt_b2s (newpath));
+
+  mutt_buffer_pool_release (&path);
+  mutt_buffer_pool_release (&newpath);
+  return rv;
 }
 
 int mutt_bcache_del(body_cache_t *bcache, const char *id)
 {
-  char path[_POSIX_PATH_MAX];
+  BUFFER *path;
+  int rv;
 
   if (!id || !*id || !bcache)
     return -1;
 
-  path[0] = '\0';
-  safe_strncat (path, sizeof (path), bcache->path, bcache->pathlen);
-  safe_strncat (path, sizeof (path), id, mutt_strlen (id));
+  path = mutt_buffer_pool_get ();
+  mutt_buffer_addstr (path, bcache->path);
+  mutt_buffer_addstr (path, id);
+
+  dprint (3, (debugfile, "bcache: del: '%s'\n", mutt_b2s (path)));
 
-  dprint (3, (debugfile, "bcache: del: '%s'\n", path));
+  rv = unlink (mutt_b2s (path));
 
-  return unlink (path);
+  mutt_buffer_pool_release (&path);
+  return rv;
 }
 
 int mutt_bcache_exists(body_cache_t *bcache, const char *id)
 {
-  char path[_POSIX_PATH_MAX];
+  BUFFER *path;
   struct stat st;
   int rc = 0;
 
   if (!id || !*id || !bcache)
     return -1;
 
-  path[0] = '\0';
-  safe_strncat (path, sizeof (path), bcache->path, bcache->pathlen);
-  safe_strncat (path, sizeof (path), id, mutt_strlen (id));
+  path = mutt_buffer_pool_get ();
+  mutt_buffer_addstr (path, bcache->path);
+  mutt_buffer_addstr (path, id);
 
-  if (stat (path, &st) < 0)
+  if (stat (mutt_b2s (path), &st) < 0)
     rc = -1;
   else
     rc = S_ISREG(st.st_mode) && st.st_size != 0 ? 0 : -1;
 
-  dprint (3, (debugfile, "bcache: exists: '%s': %s\n", path, rc == 0 ? "yes" : "no"));
+  dprint (3, (debugfile, "bcache: exists: '%s': %s\n",
+              mutt_b2s (path), rc == 0 ? "yes" : "no"));
 
+  mutt_buffer_pool_release (&path);
   return rc;
 }
 
diff --git a/muttlib.c b/muttlib.c
index 9a758b01..82f90faf 100644
--- a/muttlib.c
+++ b/muttlib.c
@@ -2256,6 +2256,18 @@ void mutt_encode_path (char *dest, size_t dlen, const char *src)
   FREE (&p);
 }
 
+void mutt_buffer_encode_path (BUFFER *dest, const char *src)
+{
+  char *p;
+  int rc;
+
+  p = safe_strdup (src);
+  rc = mutt_convert_string (&p, Charset, "utf-8", 0);
+  /* `src' may be NULL, such as when called from the pop3 driver. */
+  mutt_buffer_strcpy (dest, (rc == 0) ? NONULL(p) : NONULL(src));
+  FREE (&p);
+}
+
 
 /************************************************************************
  * These functions are transplanted from lib.c, in order to modify them *
diff --git a/protos.h b/protos.h
index 8eec3b15..66348bc3 100644
--- a/protos.h
+++ b/protos.h
@@ -205,6 +205,7 @@ void mutt_curses_error (const char *, ...);
 void mutt_curses_message (const char *, ...);
 void mutt_encode_descriptions (BODY *, short);
 void mutt_encode_path (char *, size_t, const char *);
+void mutt_buffer_encode_path (BUFFER *, const char *);
 void mutt_enter_command (void);
 void mutt_error_history_display (void);
 void mutt_error_history_init (void);