From: Graham Leggett <minfrin@apache.org>
Date: Wed, 15 May 2013 15:05:28 +0000 (+0000)
Subject: mod_serf: Add a FIXME, we are using ap_get_client_block() incorrectly.
X-Git-Tag: 2.5.0-alpha~5453
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ad639270e7ce62617025deca112b2a4bf287db0f;p=apache

mod_serf: Add a FIXME, we are using ap_get_client_block() incorrectly.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1482883 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/modules/proxy/mod_serf.c b/modules/proxy/mod_serf.c
index 52260275d0..463833ea06 100644
--- a/modules/proxy/mod_serf.c
+++ b/modules/proxy/mod_serf.c
@@ -539,6 +539,7 @@ static int drive_serf(request_rec *r, serf_config_t *conf)
 
         do {
             len = sizeof(buf);
+            /* FIXME: ap_get_client_block() returns long, not apr_status_t */
             rv = ap_get_client_block(baton->r, buf, len);
             if (rv > 0) {
                 rv = apr_file_write_full(fp, buf, rv, NULL);