From: Robert Haas <rhaas@postgresql.org>
Date: Thu, 1 Feb 2018 20:21:13 +0000 (-0500)
Subject: Fix possible failure to mark hash metapage dirty.
X-Git-Tag: REL_11_BETA1~839
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ad25a6b1f25baf09c869c903c9c8e26d390875f5;p=postgresql

Fix possible failure to mark hash metapage dirty.

Report and suggested fix by Lixian Zou.  Amit Kapila put it
in the form of a patch and reviewed.

Discussion: http://postgr.es/m/151739848647.1239.12528851873396651946@wrigleys.postgresql.org
---

diff --git a/src/backend/access/hash/hashovfl.c b/src/backend/access/hash/hashovfl.c
index c9de1283dc..2033b2f7f9 100644
--- a/src/backend/access/hash/hashovfl.c
+++ b/src/backend/access/hash/hashovfl.c
@@ -341,9 +341,10 @@ found:
 			metap->hashm_mapp[metap->hashm_nmaps] = BufferGetBlockNumber(newmapbuf);
 			metap->hashm_nmaps++;
 			metap->hashm_spares[splitnum]++;
-			MarkBufferDirty(metabuf);
 		}
 
+		MarkBufferDirty(metabuf);
+
 		/*
 		 * for new overflow page, we don't need to explicitly set the bit in
 		 * bitmap page, as by default that will be set to "in use".