From: Ben Langmuir <blangmuir@apple.com>
Date: Fri, 30 May 2014 17:54:59 +0000 (+0000)
Subject: Revert "Invalidate the file system cache entries for files that may rebuild"
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=acdc0afb1e492dc10cd8b5e6ad789c3a885ecef5;p=clang

Revert "Invalidate the file system cache entries for files that may rebuild"

This reverts commit r209910, which is breaking some of the bots.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@209911 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Serialization/ModuleManager.cpp b/lib/Serialization/ModuleManager.cpp
index 7b68726143..5613d372d2 100644
--- a/lib/Serialization/ModuleManager.cpp
+++ b/lib/Serialization/ModuleManager.cpp
@@ -135,32 +135,19 @@ ModuleManager::addModule(StringRef FileName, ModuleKind Type,
   return NewModule? NewlyLoaded : AlreadyLoaded;
 }
 
-static void invalidateFileCacheForFileAndImporters(
-    ModuleFile *F, FileManager &FileMgr,
-    llvm::SmallPtrSetImpl<ModuleFile *> &VictimSet) {
-  assert(VictimSet.count(F) && "removeModules() missing ancestor of module "
-         "that failed to load");
-  FileMgr.invalidateCache(F->File);
-  F->File = nullptr;
-  for (ModuleFile *Importer : F->ImportedBy)
-    invalidateFileCacheForFileAndImporters(Importer, FileMgr, VictimSet);
-}
-
 void ModuleManager::removeModules(ModuleIterator first, ModuleIterator last,
                                   ModuleMap *modMap) {
   if (first == last)
     return;
 
+  // The first file entry is about to be rebuilt (or there was an error), so
+  // there should be no references to it. Remove it from the cache to close it,
+  // as Windows doesn't seem to allow renaming over an open file.
+  FileMgr.invalidateCache((*first)->File);
+
   // Collect the set of module file pointers that we'll be removing.
   llvm::SmallPtrSet<ModuleFile *, 4> victimSet(first, last);
 
-  // The last module file caused the load failure, so it and its ancestors in
-  // the module dependency tree will be rebuilt (or there was an error), so
-  // there should be no references to them. Remove them from the cache,
-  // since rebuilding them will create new files at the old locations.
-  invalidateFileCacheForFileAndImporters(*(last-1), FileMgr, victimSet);
-  assert((*first)->File == nullptr && "non-dependent module loaded");
-
   // Remove any references to the now-destroyed modules.
   for (unsigned i = 0, n = Chain.size(); i != n; ++i) {
     Chain[i]->ImportedBy.remove_if([&](ModuleFile *MF) {