From: Magnus Jacobsson <Magnus.Jacobsson@berotec.se>
Date: Sat, 11 Dec 2021 14:29:24 +0000 (+0100)
Subject: sparse: MSBuild: define GVDLL to ensure correct storage-class attributes
X-Git-Tag: 3.0.0~118^2~4
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ac94ad4994e1086fd6fe92fc6b6b740884836bc4;p=graphviz

sparse: MSBuild: define GVDLL to ensure correct storage-class attributes

An upcoming commit that removes the common/globals.h symbols from the
gvc.def file would otherwise cause errors like this:

sparse.lib(DotIO.obj) : error LNK2001: unresolved external symbol _Verbose

Towards https://gitlab.com/graphviz/graphviz/-/issues/2058.
---

diff --git a/lib/sparse/gvsparse.vcxproj b/lib/sparse/gvsparse.vcxproj
index 8b4938016..2dd003017 100644
--- a/lib/sparse/gvsparse.vcxproj
+++ b/lib/sparse/gvsparse.vcxproj
@@ -52,7 +52,7 @@
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
     <ClCompile>
       <Optimization>Disabled</Optimization>
-      <PreprocessorDefinitions>_DEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
+      <PreprocessorDefinitions>_DEBUG;_LIB;GVDLL;%(PreprocessorDefinitions)</PreprocessorDefinitions>
       <BasicRuntimeChecks>EnableFastChecks</BasicRuntimeChecks>
       <RuntimeLibrary>MultiThreadedDebugDLL</RuntimeLibrary>
       <PrecompiledHeader />
@@ -66,7 +66,7 @@
   </ItemDefinitionGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
     <ClCompile>
-      <PreprocessorDefinitions>NDEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
+      <PreprocessorDefinitions>NDEBUG;_LIB;GVDLL;%(PreprocessorDefinitions)</PreprocessorDefinitions>
       <PrecompiledHeader />
       <WarningLevel>Level4</WarningLevel>
       <EnablePREfast>true</EnablePREfast>