From: Wez Furlong <wez@php.net>
Date: Tue, 31 Dec 2002 11:42:15 +0000 (+0000)
Subject: Fix for #21304 (gzopen did not report errors on open; "a" mode broken)
X-Git-Tag: PHP_5_0_dev_before_13561_fix~550
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=abc4b4bb99d998a57b8a4f9ab6edfefcd6130b60;p=php

Fix for #21304 (gzopen did not report errors on open; "a" mode broken)
---

diff --git a/ext/zlib/zlib.c b/ext/zlib/zlib.c
index 798c2529f3..2fc828d5c9 100644
--- a/ext/zlib/zlib.c
+++ b/ext/zlib/zlib.c
@@ -352,7 +352,7 @@ PHP_FUNCTION(gzopen)
 	convert_to_string_ex(arg2);
 	p = estrndup(Z_STRVAL_PP(arg2),Z_STRLEN_PP(arg2));
 	
-	stream = php_stream_gzopen(NULL, Z_STRVAL_PP(arg1), p, use_include_path|ENFORCE_SAFE_MODE, NULL, NULL STREAMS_CC TSRMLS_CC);
+	stream = php_stream_gzopen(NULL, Z_STRVAL_PP(arg1), p, use_include_path|ENFORCE_SAFE_MODE|REPORT_ERRORS, NULL, NULL STREAMS_CC TSRMLS_CC);
 	if (!stream) {
 		RETURN_FALSE;
 	}
diff --git a/ext/zlib/zlib_fopen_wrapper.c b/ext/zlib/zlib_fopen_wrapper.c
index 6f50a5aa52..b9fff31bb4 100644
--- a/ext/zlib/zlib_fopen_wrapper.c
+++ b/ext/zlib/zlib_fopen_wrapper.c
@@ -107,12 +107,6 @@ php_stream *php_stream_gzopen(php_stream_wrapper *wrapper, char *path, char *mod
 		}
 		return NULL;
 	}
-	if (strchr(mode, 'a')) {
-		if (options & REPORT_ERRORS) {
-			php_error_docref(NULL TSRMLS_CC, E_WARNING, "cannot append to a zlib stream!");
-		}
-		return NULL;
-	}
 	
 	self = emalloc(sizeof(*self));