From: Moriyoshi Koizumi <moriyoshi@php.net>
Date: Mon, 18 Aug 2008 03:26:06 +0000 (+0000)
Subject: - Beware of signedness
X-Git-Tag: BEFORE_HEAD_NS_CHANGE~674
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ab976fe2d4fcd085334dbc4a018e1c39222b636f;p=php

- Beware of signedness
---

diff --git a/ext/standard/html.c b/ext/standard/html.c
index abc8347499..2b0920722c 100644
--- a/ext/standard/html.c
+++ b/ext/standard/html.c
@@ -1201,21 +1201,21 @@ encode_amp:
 							if (*s == 'x' || *s == 'X') {
 								s++;
 								while (s < e) {
-									if (!isxdigit(*s++)) {
+									if (!isxdigit((int)*(unsigned char *)s++)) {
 										goto encode_amp;
 									}
 								}
 							/* Dec (&#90;)*/
 							} else {
 								while (s < e) {
-									if (!isdigit(*s++)) {
+									if (!isdigit((int)*(unsigned char *)s++)) {
 										goto encode_amp;
 									}
 								}
 							}
 						} else { /* text entities */
 							while (s < e) {
-								if (!isalnum(*s++)) {
+								if (!isalnum((int)*(unsigned char *)s++)) {
 									goto encode_amp;
 								}
 							}