From: Todd C. Miller <Todd.Miller@courtesan.com>
Date: Mon, 24 Oct 2011 15:14:20 +0000 (-0400)
Subject: Get rid of done: label.  If the child exits we still need to close
X-Git-Tag: SUDO_1_8_4~181^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ab75dd2e306a92e491bc4fae9876c84d311a166c;p=sudo

Get rid of done: label.  If the child exits we still need to close
the pty, update utmp and restore the SELinux tty context.
---

diff --git a/src/exec.c b/src/exec.c
index 3853d347a..2d6d8605f 100644
--- a/src/exec.c
+++ b/src/exec.c
@@ -341,7 +341,7 @@ sudo_execve(struct command_details *details, struct command_status *cstat)
 	    n = handle_signals(signal_pipe[0], child, log_io, cstat);
 	    if (n == 0) {
 		/* Child has exited, cstat is set, we are done. */
-		goto done;
+		break;
 	    }
 	    if (n == -1) {
 		/* Error reading signal_pipe[0], should not happen. */
@@ -405,7 +405,6 @@ sudo_execve(struct command_details *details, struct command_status *cstat)
     }
 #endif
 
-done:
     efree(fdsr);
     efree(fdsw);
     while (!tq_empty(&sigfwd_list)) {