From: Neal Norwitz <nnorwitz@gmail.com>
Date: Sun, 12 Aug 2007 17:21:38 +0000 (+0000)
Subject: Add comment that should be addressed
X-Git-Tag: v3.0a1~425
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ab40b30398920884fff8ca1c5f89bf54ad8ae0bf;p=python

Add comment that should be addressed
---

diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
index 6b27adb73c..47109a5b3c 100644
--- a/Objects/unicodeobject.c
+++ b/Objects/unicodeobject.c
@@ -1188,6 +1188,9 @@ PyObject *_PyUnicode_AsDefaultEncodedString(PyObject *unicode,
         return v;
     if (errors != NULL)
         Py_FatalError("non-NULL encoding in _PyUnicode_AsDefaultEncodedString");
+    /* XXX(nnorwitz): errors will always be NULL due to the check above.
+	Should this check and the else be removed since it's dead code?
+     */
     if (errors == NULL) {
         b = PyUnicode_EncodeUTF8(PyUnicode_AS_UNICODE(unicode),
                                  PyUnicode_GET_SIZE(unicode),