From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Sun, 29 Mar 2015 19:04:09 +0000 (-0400)
Subject: Add vacuum_delay_point call in compute_index_stats's per-sample-row loop.
X-Git-Tag: REL9_1_16~45
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ab02d35e08274f2c1084e00e5106e72863a6c85b;p=postgresql

Add vacuum_delay_point call in compute_index_stats's per-sample-row loop.

Slow functions in index expressions might cause this loop to take long
enough to make it worth being cancellable.  Probably it would be enough
to call CHECK_FOR_INTERRUPTS here, but for consistency with other
per-sample-row loops in this file, let's use vacuum_delay_point.

Report and patch by Jeff Janes.  Back-patch to all supported branches.
---

diff --git a/src/backend/commands/analyze.c b/src/backend/commands/analyze.c
index 0e876904d9..53fded1795 100644
--- a/src/backend/commands/analyze.c
+++ b/src/backend/commands/analyze.c
@@ -693,6 +693,8 @@ compute_index_stats(Relation onerel, double totalrows,
 		{
 			HeapTuple	heapTuple = rows[rowno];
 
+			vacuum_delay_point();
+
 			/*
 			 * Reset the per-tuple context each time, to reclaim any cruft
 			 * left behind by evaluating the predicate or index expressions.