From: Senthil Kumaran Date: Fri, 19 Feb 2010 07:39:41 +0000 (+0000) Subject: Merged revisions 78234 via svnmerge from X-Git-Tag: v2.6.5rc1~62 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=aaa210e2fdc96030439bf694fae1994cac495565;p=python Merged revisions 78234 via svnmerge from svn+ssh://pythondev@svn.python.org/python/trunk ........ r78234 | senthil.kumaran | 2010-02-19 13:02:48 +0530 (Fri, 19 Feb 2010) | 2 lines Fix for Issue7904. urlparse.urlsplit to handle schemes in the way defined by RFC3986 ........ --- diff --git a/Lib/test/test_urlparse.py b/Lib/test/test_urlparse.py index fcd19894b9..0f306a98d5 100644 --- a/Lib/test/test_urlparse.py +++ b/Lib/test/test_urlparse.py @@ -138,7 +138,7 @@ class UrlParseTestCase(unittest.TestCase): (base, relurl, expected)) def test_unparse_parse(self): - for u in ['Python', './Python']: + for u in ['Python', './Python','x-newscheme://foo.com/stuff']: self.assertEqual(urlparse.urlunsplit(urlparse.urlsplit(u)), u) self.assertEqual(urlparse.urlunparse(urlparse.urlparse(u)), u) @@ -350,6 +350,15 @@ class UrlParseTestCase(unittest.TestCase): self.assertEqual(urlparse.urlparse("http://example.com?blahblah=/foo"), ('http', 'example.com', '', '', 'blahblah=/foo', '')) + def test_anyscheme(self): + # Issue 7904: s3://foo.com/stuff has netloc "foo.com". + self.assertEqual(urlparse.urlparse("s3://foo.com/stuff"), + ('s3','foo.com','/stuff','','','')) + self.assertEqual(urlparse.urlparse("x-newscheme://foo.com/stuff"), + ('x-newscheme','foo.com','/stuff','','','')) + + + def test_main(): test_support.run_unittest(UrlParseTestCase) diff --git a/Lib/urlparse.py b/Lib/urlparse.py index c56d8832a0..c41e25eea1 100644 --- a/Lib/urlparse.py +++ b/Lib/urlparse.py @@ -163,7 +163,8 @@ def urlsplit(url, scheme='', allow_fragments=True): break else: scheme, url = url[:i].lower(), url[i+1:] - if scheme in uses_netloc and url[:2] == '//': + + if url[:2] == '//': netloc, url = _splitnetloc(url, 2) if allow_fragments and scheme in uses_fragment and '#' in url: url, fragment = url.split('#', 1)