From: Florent Xicluna <florent.xicluna@gmail.com>
Date: Sat, 6 Mar 2010 09:54:14 +0000 (+0000)
Subject: #2777: Apply same recipe on win32, i.e. do not inherit file handles.
X-Git-Tag: v2.7a4~9
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=aa90db947777d7534eb47f5b3184e87d0901fc63;p=python

#2777: Apply same recipe on win32, i.e. do not inherit file handles.
---

diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py
index cd378a231d..7e96c214e0 100644
--- a/Lib/test/test_subprocess.py
+++ b/Lib/test/test_subprocess.py
@@ -769,21 +769,23 @@ class Win32ProcessTestCase(unittest.TestCase):
         self.assertEqual(rc, 47)
 
     def test_send_signal(self):
-        p = subprocess.Popen([sys.executable, "-c", "input()"])
+        # Do not inherit file handles from the parent.
+        # It should fix failure on some platforms.
+        p = subprocess.Popen([sys.executable, "-c", "input()"], close_fds=True)
 
         self.assertIs(p.poll(), None)
         p.send_signal(signal.SIGTERM)
         self.assertNotEqual(p.wait(), 0)
 
     def test_kill(self):
-        p = subprocess.Popen([sys.executable, "-c", "input()"])
+        p = subprocess.Popen([sys.executable, "-c", "input()"], close_fds=True)
 
         self.assertIs(p.poll(), None)
         p.kill()
         self.assertNotEqual(p.wait(), 0)
 
     def test_terminate(self):
-        p = subprocess.Popen([sys.executable, "-c", "input()"])
+        p = subprocess.Popen([sys.executable, "-c", "input()"], close_fds=True)
 
         self.assertIs(p.poll(), None)
         p.terminate()