From: Senthil Kumaran <orsenthil@gmail.com>
Date: Sun, 3 Oct 2010 18:26:07 +0000 (+0000)
Subject: Merged revisions 85205 via svnmerge from
X-Git-Tag: v2.7.1rc1~210
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=aa5f49e4c132c217ffacb85261443408c3a524df;p=python

Merged revisions 85205 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r85205 | senthil.kumaran | 2010-10-03 23:52:42 +0530 (Sun, 03 Oct 2010) | 3 lines

  Fix Issue10012 - httplib headers, which are (sometimes mistakenly) int are explicitly cast to str (bytes - in py3k).
........
---

diff --git a/Lib/httplib.py b/Lib/httplib.py
index eb10ebad5d..526509c01f 100644
--- a/Lib/httplib.py
+++ b/Lib/httplib.py
@@ -915,7 +915,7 @@ class HTTPConnection:
         if self.__state != _CS_REQ_STARTED:
             raise CannotSendHeader()
 
-        hdr = '%s: %s' % (header, '\r\n\t'.join(values))
+        hdr = '%s: %s' % (header, '\r\n\t'.join([str(v) for v in values]))
         self._output(hdr)
 
     def endheaders(self, message_body=None):
diff --git a/Lib/test/test_httplib.py b/Lib/test/test_httplib.py
index 435a9fc8b8..74301ff39a 100644
--- a/Lib/test/test_httplib.py
+++ b/Lib/test/test_httplib.py
@@ -1,3 +1,4 @@
+import httplib
 import array
 import httplib
 import StringIO
@@ -64,8 +65,6 @@ class HeaderTests(TestCase):
         # Some headers are added automatically, but should not be added by
         # .request() if they are explicitly set.
 
-        import httplib
-
         class HeaderCountingBuffer(list):
             def __init__(self):
                 self.count = {}
@@ -91,6 +90,13 @@ class HeaderTests(TestCase):
                 conn.request('POST', '/', body, headers)
                 self.assertEqual(conn._buffer.count[header.lower()], 1)
 
+    def test_putheader(self):
+        conn = httplib.HTTPConnection('example.com')
+        conn.sock = FakeSocket(None)
+        conn.putrequest('GET','/')
+        conn.putheader('Content-length',42)
+        self.assertTrue('Content-length: 42' in conn._buffer)
+
 class BasicTest(TestCase):
     def test_status_lines(self):
         # Test HTTP status lines