From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Sun, 19 Sep 2021 21:25:06 +0000 (-0700)
Subject: lefty SFcompareEntries: remove MSVC 'strcascmp' fall back
X-Git-Tag: 2.49.2~41^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=aa322a2f4b2df8f898844e7dbf84e4a1aab3f4a2;p=graphviz

lefty SFcompareEntries: remove MSVC 'strcascmp' fall back

Commit 1c2c986ebb2d16e491c68656217f5352b3d809c8 replaced `SFCompareEntries`
implementation with `strcasecmp` or `_stricmp` depending on whether we were
compiling with a non-MSVC compiler or with MSVC, respectively. However, this
code is part of the X11 GUI support and hence never built with MSVC. This commit
removes this unnecessary fall back which was dead code.
---

diff --git a/cmd/lefty/ws/x11/libfilereq/Dir.c b/cmd/lefty/ws/x11/libfilereq/Dir.c
index 14d6b4312..db75d851e 100644
--- a/cmd/lefty/ws/x11/libfilereq/Dir.c
+++ b/cmd/lefty/ws/x11/libfilereq/Dir.c
@@ -40,9 +40,7 @@
 #include "config.h"
 #include <stdio.h>
 #include <string.h>
-#ifndef _MSC_VER
 #include <strings.h>
-#endif
 
 #include "SFinternal.h"
 
@@ -57,11 +55,7 @@
 int SFcompareEntries (const void *vp, const void *vq) {
     const SFEntry *p = vp, *q = vq;
 #ifdef SEL_FILE_IGNORE_CASE
-#ifdef _MSC_VER
-    return _stricmp(p->real, q->real);
-#else
     return strcasecmp(p->real, q->real);
-#endif
 #else /* def SEL_FILE_IGNORE_CASE */
     return strcmp (p->real, q->real);
 #endif /* def SEL_FILE_IGNORE_CASE */