From: Dmitry Stogov Date: Mon, 8 Sep 2014 20:40:14 +0000 (+0400) Subject: We don't need to check for xlat entry twice X-Git-Tag: PRE_PHP7_REMOVALS~94 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a9d985263a8a3c0a654f466c32ff9b54b7a6116f;p=php We don't need to check for xlat entry twice --- diff --git a/ext/opcache/zend_persist.c b/ext/opcache/zend_persist.c index b34e90578d..b2b863c5a9 100644 --- a/ext/opcache/zend_persist.c +++ b/ext/opcache/zend_persist.c @@ -198,9 +198,7 @@ static void zend_persist_zval(zval *z TSRMLS_DC) Z_ARR_P(z) = zend_accel_memdup(Z_ARR_P(z), sizeof(zend_array)); zend_hash_persist_immutable(Z_ARRVAL_P(z) TSRMLS_CC); } else { - if (!zend_shared_alloc_get_xlat_entry(Z_ARR_P(z))) { - GC_REMOVE_FROM_BUFFER(Z_ARR_P(z)); - } + GC_REMOVE_FROM_BUFFER(Z_ARR_P(z)); zend_accel_store(Z_ARR_P(z), sizeof(zend_array)); zend_hash_persist(Z_ARRVAL_P(z), zend_persist_zval TSRMLS_CC); /* make immutable array */ @@ -254,9 +252,7 @@ static void zend_persist_zval_const(zval *z TSRMLS_DC) Z_ARR_P(z) = zend_accel_memdup(Z_ARR_P(z), sizeof(zend_array)); zend_hash_persist_immutable(Z_ARRVAL_P(z) TSRMLS_CC); } else { - if (!zend_shared_alloc_get_xlat_entry(Z_ARR_P(z))) { - GC_REMOVE_FROM_BUFFER(Z_ARR_P(z)); - } + GC_REMOVE_FROM_BUFFER(Z_ARR_P(z)); zend_accel_store(Z_ARR_P(z), sizeof(zend_array)); zend_hash_persist(Z_ARRVAL_P(z), zend_persist_zval TSRMLS_CC); /* make immutable array */