From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Sat, 18 Nov 2017 21:46:30 +0000 (-0500)
Subject: Fix compiler warning in rangetypes_spgist.c.
X-Git-Tag: REL9_6_7~70
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a96e2252833542ab8f79eb27a23941ab8cf0d7d1;p=postgresql

Fix compiler warning in rangetypes_spgist.c.

On gcc 7.2.0, comparing pointer to (Datum) 0 produces a warning.
Treat it as a simple pointer to avoid that; this is more consistent
with comparable code elsewhere, anyway.

Tomas Vondra

Discussion: https://postgr.es/m/99410021-61ef-9a9a-9bc8-f733ece637ee@2ndquadrant.com
---

diff --git a/src/backend/utils/adt/rangetypes_spgist.c b/src/backend/utils/adt/rangetypes_spgist.c
index b89e90f908..72d97986a3 100644
--- a/src/backend/utils/adt/rangetypes_spgist.c
+++ b/src/backend/utils/adt/rangetypes_spgist.c
@@ -563,7 +563,7 @@ spg_range_quad_inner_consistent(PG_FUNCTION_ARGS)
 					 * for lower or upper bounds to be adjacent. Deserialize
 					 * previous centroid range if present for checking this.
 					 */
-					if (in->traversalValue != (Datum) 0)
+					if (in->traversalValue)
 					{
 						prevCentroid = DatumGetRangeType(in->traversalValue);
 						range_deserialize(typcache, prevCentroid,