From: Ted Kremenek <kremenek@apple.com>
Date: Fri, 25 Jul 2008 18:17:35 +0000 (+0000)
Subject: Remove call to isSEL and isSEL itself since the call is dead (isObjCObjectPointerType... 
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a95acd672d2ba38b3016a345681889299ce828f9;p=clang

Remove call to isSEL and isSEL itself since the call is dead (isObjCObjectPointerType() will never return true for selectors).


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@54034 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Analysis/CheckObjCDealloc.cpp b/lib/Analysis/CheckObjCDealloc.cpp
index ba0eb6ac6a..39d1e05b94 100644
--- a/lib/Analysis/CheckObjCDealloc.cpp
+++ b/lib/Analysis/CheckObjCDealloc.cpp
@@ -42,13 +42,6 @@ static bool scan_dealloc(Stmt* S, Selector Dealloc) {
   return false;
 }
 
-static bool isSEL(QualType T, IdentifierInfo* SelII) {
-  if (const TypedefType* Ty = T->getAsTypedefType())
-    return Ty->getDecl()->getIdentifier() == SelII;
-  
-  return false;
-}
-
 void clang::CheckObjCDealloc(ObjCImplementationDecl* D,
                              const LangOptions& LOpts, BugReporter& BR) {
 
@@ -63,7 +56,6 @@ void clang::CheckObjCDealloc(ObjCImplementationDecl* D,
   //        http://llvm.org/bugs/show_bug.cgi?id=2517
   
   bool containsPointerIvar = false;
-  IdentifierInfo* SelII = &Ctx.Idents.get("SEL");
   
   for (ObjCInterfaceDecl::ivar_iterator I=ID->ivar_begin(), E=ID->ivar_end();
        I!=E; ++I) {
@@ -72,8 +64,7 @@ void clang::CheckObjCDealloc(ObjCImplementationDecl* D,
     QualType T = ID->getType();
     
     if (!Ctx.isObjCObjectPointerType(T) ||
-        ID->getAttr<IBOutletAttr>() || // Skip IBOutlets.
-        isSEL(T, SelII)) // Skip SEL ivars.
+        ID->getAttr<IBOutletAttr>()) // Skip IBOutlets.
       continue;
     
     containsPointerIvar = true;