From: Giuseppe Di Natale Date: Fri, 27 Oct 2017 16:52:18 +0000 (-0700) Subject: Correct make mancheck recipe X-Git-Tag: zfs-0.8.0-rc1~495 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a94d38c0f382c16244912de83a7356ae35e63322;p=zfs Correct make mancheck recipe The current make recipe for mancheck silently ignores errors. Correct the recipe so errors cause the mancheck recipe fail. The zpool reopen command in the zpool.8 manpage had a bullet list without an .El. Reviewed-by: George Melikov Reviewed-by: Brian Behlendorf Reviewed-by: loli10K Signed-off-by: Giuseppe Di Natale Closes #6790 --- diff --git a/Makefile.am b/Makefile.am index c51be2b4c..05cafc702 100644 --- a/Makefile.am +++ b/Makefile.am @@ -62,9 +62,10 @@ shellcheck: mancheck: @if type mandoc > /dev/null 2>&1; then \ - for file in zfs zpool zdb zgenhostid; do \ - mandoc -Tlint -Werror ${top_srcdir}/man/man8/$$file.8; \ - done \ + find ${top_srcdir}/man/man8 -type f -name 'zfs.8' \ + -o -name 'zpool.8' -o -name 'zdb.8' \ + -o -name 'zgenhostid.8' | \ + xargs mandoc -Tlint -Werror; \ fi lint: cppcheck paxcheck diff --git a/man/man8/zpool.8 b/man/man8/zpool.8 index 4eea6689d..58bf66c91 100644 --- a/man/man8/zpool.8 +++ b/man/man8/zpool.8 @@ -1747,6 +1747,7 @@ Reopen all the vdevs associated with the pool. .It Fl n Do not restart an in-progress scrub operation. This is not recommended and can result in partially resilvered devices unless a second scrub is performed. +.El .It Xo .Nm .Cm remove