From: Felipe Pena <felipe@php.net>
Date: Fri, 21 Nov 2008 22:27:02 +0000 (+0000)
Subject: - MFH: Fixed memory leak in readline_callback_handler_remove()
X-Git-Tag: php-5.3.0alpha2~104
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a9455b5be6e3b141cb6add3d3d7535fc2e274c95;p=php

- MFH: Fixed memory leak in readline_callback_handler_remove()
---

diff --git a/ext/readline/readline.c b/ext/readline/readline.c
index 766a9d79de..596840d768 100644
--- a/ext/readline/readline.c
+++ b/ext/readline/readline.c
@@ -551,7 +551,8 @@ PHP_FUNCTION(readline_callback_handler_install)
 
 	if (_prepped_callback) {
 		rl_callback_handler_remove();
-		zval_ptr_dtor(&_prepped_callback);
+		zval_dtor(_prepped_callback);
+		FREE_ZVAL(_prepped_callback);
 	}
 
 	MAKE_STD_ZVAL(_prepped_callback);
@@ -580,6 +581,7 @@ PHP_FUNCTION(readline_callback_handler_remove)
 {
 	if (_prepped_callback) {
 		rl_callback_handler_remove();
+		zval_dtor(_prepped_callback);
 		FREE_ZVAL(_prepped_callback);
 		_prepped_callback = 0;
 		RETURN_TRUE;