From: Guido van Rossum <guido@python.org>
Date: Fri, 24 Apr 1998 18:22:02 +0000 (+0000)
Subject: Fred's right -- we need PyList_SET_ITEM().
X-Git-Tag: v1.5.2a1~835
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a937d14898e8e396a1c9acc0fbd2db5209d1a6ce;p=python

Fred's right -- we need PyList_SET_ITEM().
---

diff --git a/Doc/api.tex b/Doc/api.tex
index 5f168f2f98..b0b7bfd14a 100644
--- a/Doc/api.tex
+++ b/Doc/api.tex
@@ -1953,6 +1953,11 @@ Returns a new tuple object containing the contents of \var{list}.
 Macro form of \cfunction{PyList_GetItem()} without error checking.
 \end{cfuncdesc}
 
+\begin{cfuncdesc}{PyObject*}{PyList_SET_ITEM}{PyObject *list, int i,
+                                              PyObject *o}
+Macro form of \cfunction{PyList_SetItem()} without error checking.
+\end{cfuncdesc}
+
 \begin{cfuncdesc}{int}{PyList_GET_SIZE}{PyObject *list}
 Macro form of \cfunction{PyList_GetSize()} without error checking.
 \end{cfuncdesc}
diff --git a/Doc/api/api.tex b/Doc/api/api.tex
index 5f168f2f98..b0b7bfd14a 100644
--- a/Doc/api/api.tex
+++ b/Doc/api/api.tex
@@ -1953,6 +1953,11 @@ Returns a new tuple object containing the contents of \var{list}.
 Macro form of \cfunction{PyList_GetItem()} without error checking.
 \end{cfuncdesc}
 
+\begin{cfuncdesc}{PyObject*}{PyList_SET_ITEM}{PyObject *list, int i,
+                                              PyObject *o}
+Macro form of \cfunction{PyList_SetItem()} without error checking.
+\end{cfuncdesc}
+
 \begin{cfuncdesc}{int}{PyList_GET_SIZE}{PyObject *list}
 Macro form of \cfunction{PyList_GetSize()} without error checking.
 \end{cfuncdesc}
diff --git a/Include/listobject.h b/Include/listobject.h
index c1bbcc17f5..e99acef1b9 100644
--- a/Include/listobject.h
+++ b/Include/listobject.h
@@ -74,6 +74,7 @@ extern PyObject *PyList_AsTuple Py_PROTO((PyObject *));
 
 /* Macro, trading safety for speed */
 #define PyList_GET_ITEM(op, i) (((PyListObject *)(op))->ob_item[i])
+#define PyList_SET_ITEM(op, i, v) (((PyListObject *)(op))->ob_item[i] = (v))
 #define PyList_GET_SIZE(op)    (((PyListObject *)(op))->ob_size)
 
 #ifdef __cplusplus
diff --git a/Python/bltinmodule.c b/Python/bltinmodule.c
index 8a4215bad5..fd31405733 100644
--- a/Python/bltinmodule.c
+++ b/Python/bltinmodule.c
@@ -1282,7 +1282,7 @@ builtin_range(self, args)
 			Py_DECREF(v);
 			return NULL;
 		}
-		PyList_GET_ITEM(v, i) = w;
+		PyList_SET_ITEM(v, i, w);
 		ilow += istep;
 	}
 	return v;