From: Noah Misch <noah@leadboat.com>
Date: Sat, 3 Dec 2016 20:46:35 +0000 (-0500)
Subject: Remove wrong CloseHandle() call.
X-Git-Tag: REL9_2_20~56
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a9265258af9597f3a69bcb8dadfc94cc6afdf0c7;p=postgresql

Remove wrong CloseHandle() call.

In accordance with its own documentation, invoke CloseHandle() only when
directed in the documentation for the function that furnished the
handle.  GetModuleHandle() does not so direct.  We have been issuing
this call only in the rare event that a CRT DLL contains no "_putenv"
symbol, so lack of bug reports is uninformative.  Back-patch to 9.2 (all
supported versions).

Christian Ullrich, reviewed by Michael Paquier.
---

diff --git a/src/port/win32env.c b/src/port/win32env.c
index e934a8f76d..40df88990f 100644
--- a/src/port/win32env.c
+++ b/src/port/win32env.c
@@ -86,7 +86,6 @@ pgwin32_putenv(const char *envval)
 					rtmodules[i].putenvFunc = (PUTENVPROC) GetProcAddress(rtmodules[i].hmodule, "_putenv");
 					if (rtmodules[i].putenvFunc == NULL)
 					{
-						CloseHandle(rtmodules[i].hmodule);
 						rtmodules[i].hmodule = INVALID_HANDLE_VALUE;
 						continue;
 					}