From: Neil Schemenauer <nascheme@enme.ucalgary.ca>
Date: Mon, 3 Sep 2001 15:47:21 +0000 (+0000)
Subject: Don't use dir() to find instance attribute names.
X-Git-Tag: v2.2a3~143
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a8aefe535c879c8b0f5201961648a89c8e3d7887;p=python

Don't use dir() to find instance attribute names.
---

diff --git a/Lib/distutils/dist.py b/Lib/distutils/dist.py
index 3803f5cc68..40dcc96e27 100644
--- a/Lib/distutils/dist.py
+++ b/Lib/distutils/dist.py
@@ -122,9 +122,7 @@ class Distribution:
         # worth it.  Also delegate 'get_XXX()' methods to the 'metadata'
         # object in a sneaky and underhanded (but efficient!) way.
         self.metadata = DistributionMetadata()
-        method_basenames = dir(self.metadata) + \
-                           ['fullname', 'contact', 'contact_email']
-        for basename in method_basenames:
+        for basename in self.metadata._METHOD_BASENAMES:
             method_name = "get_" + basename
             setattr(self, method_name, getattr(self.metadata, method_name))
 
@@ -962,6 +960,12 @@ class DistributionMetadata:
     author, and so forth.
     """
 
+    _METHOD_BASENAMES = ("name", "version", "author", "author_email",
+                         "maintainer", "maintainer_email", "url",
+                         "license", "description", "long_description",
+                         "keywords", "platforms", "fullname", "contact",
+                         "contact_email", "licence")
+
     def __init__ (self):
         self.name = None
         self.version = None