From: Daniel Stenberg <daniel@haxx.se>
Date: Fri, 23 Jun 2006 22:07:06 +0000 (+0000)
Subject: Arve Knudsen found a flaw in curl_multi_fdset() for systems where
X-Git-Tag: cares-1_3_1~2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a8ac6f1dc15056d39668bbed48fa9e7fee5e789a;p=curl

Arve Knudsen found a flaw in curl_multi_fdset() for systems where
curl_socket_t is unsigned (like Windows) that could cause it to wrongly
return a max fd of -1.
---

diff --git a/CHANGES b/CHANGES
index eee1bb3ac..6cf3d624f 100644
--- a/CHANGES
+++ b/CHANGES
@@ -6,6 +6,11 @@
 
                                   Changelog
 
+Daniel (23 June 2006)
+- Arve Knudsen found a flaw in curl_multi_fdset() for systems where
+  curl_socket_t is unsigned (like Windows) that could cause it to wrongly
+  return a max fd of -1.
+
 Daniel (20 June 2006)
 - Peter Silva introduced CURLOPT_MAX_SEND_SPEED_LARGE and
   CURLOPT_MAX_RECV_SPEED_LARGE that limit tha maximum rate libcurl is allowed
diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 7936724ef..03bf9a6a1 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -16,6 +16,7 @@ This release includes the following changes:
 
 This release includes the following bugfixes:
 
+ o curl_multi_fdset() could return a crazy max_fd value
  o Made -K on a file that couldn't be read cause a warning to be displayed.
 
 Other curl-related news:
@@ -30,6 +31,6 @@ New curl mirrors:
 This release would not have looked like this without help, code, reports and
 advice from friends like these:
 
- Dan Fandrich, Peter Silva
+ Dan Fandrich, Peter Silva, Arve Knudsen
 
         Thanks! (and sorry if I forgot to mention someone)
diff --git a/lib/multi.c b/lib/multi.c
index 9201402a2..cfb749dfd 100644
--- a/lib/multi.c
+++ b/lib/multi.c
@@ -504,7 +504,7 @@ CURLMcode curl_multi_fdset(CURLM *multi_handle,
         /* this socket is unused, break out of loop */
         break;
       else {
-        if(s > (curl_socket_t)this_max_fd)
+        if((int)s > this_max_fd)
           this_max_fd = (int)s;
       }
     }