From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed, 30 Nov 2011 05:37:06 +0000 (-0500)
Subject: Tweak previous patch to ensure edata->filename always gets initialized.
X-Git-Tag: REL9_2_BETA1~740
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a87ebace190b16bbc6454bb93bae3356712aa3ca;p=postgresql

Tweak previous patch to ensure edata->filename always gets initialized.

On a platform that isn't supplying __FILE__, previous coding would either
crash or give a stale result for the filename string.  Not sure how likely
that is, but the original code catered for it, so let's keep doing so.
---

diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 0131c06ba4..d8d059f11c 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -349,8 +349,10 @@ errstart(int elevel, const char *filename, int lineno,
 
 		/* keep only base name, useful especially for vpath builds */
 		slash = strrchr(filename, '/');
-		edata->filename = slash ? slash + 1 : filename;
+		if (slash)
+			filename = slash + 1;
 	}
+	edata->filename = filename;
 	edata->lineno = lineno;
 	edata->funcname = funcname;
 	/* the default text domain is the backend's */
@@ -1155,8 +1157,10 @@ elog_start(const char *filename, int lineno, const char *funcname)
 
 		/* keep only base name, useful especially for vpath builds */
 		slash = strrchr(filename, '/');
-		edata->filename = slash ? slash + 1 : filename;
+		if (slash)
+			filename = slash + 1;
 	}
+	edata->filename = filename;
 	edata->lineno = lineno;
 	edata->funcname = funcname;
 	/* errno is saved now so that error parameter eval can't change it */