From: Bram Moolenaar <Bram@vim.org>
Date: Fri, 11 Sep 2020 15:59:23 +0000 (+0200)
Subject: patch 8.2.1658: expand('<stack>') has trailing ".."
X-Git-Tag: v8.2.1658
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a810db3f17d477e057059c72062c08fd97bcea43;p=vim

patch 8.2.1658: expand('<stack>') has trailing ".."

Problem:    Expand('<stack>') has trailing "..".
Solution:   Remove the "..". (closes #6927)
---

diff --git a/src/scriptfile.c b/src/scriptfile.c
index 75182ca51..a8e67b98a 100644
--- a/src/scriptfile.c
+++ b/src/scriptfile.c
@@ -144,7 +144,8 @@ estack_sfile(estack_arg_T which UNUSED)
 	entry = ((estack_T *)exestack.ga_data) + idx;
 	if (entry->es_name != NULL)
 	{
-	    long lnum = 0;
+	    long    lnum = 0;
+	    char    *dots;
 
 	    len = STRLEN(entry->es_name) + 15;
 	    type_name = "";
@@ -165,16 +166,16 @@ estack_sfile(estack_arg_T which UNUSED)
 		lnum = which == ESTACK_STACK ? SOURCING_LNUM : 0;
 	    else
 		lnum = entry->es_lnum;
+	    dots = idx == exestack.ga_len - 1 ? "" : "..";
 	    if (lnum == 0)
 		// For the bottom entry of <sfile>: do not add the line number,
 		// it is used in <slnum>.  Also leave it out when the number is
 		// not set.
 		vim_snprintf((char *)ga.ga_data + ga.ga_len, len, "%s%s%s",
-				type_name, entry->es_name,
-				idx == exestack.ga_len - 1 ? "" : "..");
+				type_name, entry->es_name, dots);
 	    else
-		vim_snprintf((char *)ga.ga_data + ga.ga_len, len, "%s%s[%ld]..",
-				    type_name, entry->es_name, lnum);
+		vim_snprintf((char *)ga.ga_data + ga.ga_len, len, "%s%s[%ld]%s",
+				    type_name, entry->es_name, lnum, dots);
 	    ga.ga_len += (int)STRLEN((char *)ga.ga_data + ga.ga_len);
 	}
     }
diff --git a/src/testdir/test_expand_func.vim b/src/testdir/test_expand_func.vim
index a63cc04e1..3c430e1c6 100644
--- a/src/testdir/test_expand_func.vim
+++ b/src/testdir/test_expand_func.vim
@@ -58,7 +58,7 @@ func Test_expand_sfile_and_stack()
   END
   call writefile(lines, 'Xstack')
   source Xstack
-  call assert_match('\<Xstack\[2\]', g:stack_value)
+  call assert_match('\<Xstack\[2\]$', g:stack_value)
   call delete('Xstack')
 endfunc
 
diff --git a/src/version.c b/src/version.c
index 538682203..81c51e196 100644
--- a/src/version.c
+++ b/src/version.c
@@ -750,6 +750,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    1658,
 /**/
     1657,
 /**/