From: William A. Rowe Jr <wrowe@apache.org>
Date: Wed, 5 Jan 2005 21:23:03 +0000 (+0000)
Subject:   Fix a signedness issue that revealed a serious bug, the 'i' was
X-Git-Tag: 2.1.3~186
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a7b143ff4d19e393ed9f54e6bdc771ed47b183cf;p=apache

  Fix a signedness issue that revealed a serious bug, the 'i' was
  reused for character indexing within this loop.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@124277 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/modules/proxy/proxy_connect.c b/modules/proxy/proxy_connect.c
index 520e037d8b..fda3172211 100644
--- a/modules/proxy/proxy_connect.c
+++ b/modules/proxy/proxy_connect.c
@@ -86,7 +86,7 @@ static int proxy_connect_handler(request_rec *r, proxy_worker *worker,
     apr_pollset_t *pollset;
     apr_pollfd_t pollfd;
     const apr_pollfd_t *signalled;
-    apr_int32_t pollcnt;
+    apr_int32_t pollcnt, pi;
     apr_int16_t pollevent;
     apr_sockaddr_t *uri_addr, *connect_addr;
 
@@ -290,8 +290,8 @@ static int proxy_connect_handler(request_rec *r, proxy_worker *worker,
                      "proxy: CONNECT: woke from select(), i=%d", pollcnt);
 #endif
 
-        for (i = 0; i < pollcnt; i++) {
-            const apr_pollfd_t *cur = &signalled[i];
+        for (pi = 0; pi < pollcnt; pi++) {
+            const apr_pollfd_t *cur = &signalled[pi];
 
             if (cur->desc.s == sock) {
                 pollevent = cur->rtnevents;
@@ -341,7 +341,8 @@ static int proxy_connect_handler(request_rec *r, proxy_worker *worker,
                         i = nbytes;
 #ifdef DEBUGGING
                         ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, r->server,
-                                     "proxy: CONNECT: read %d from client", i);
+                                     "proxy: CONNECT: read %d from client", 
+                                     );
 #endif
                         while(i > 0)
                         {