From: Benjamin Peterson <benjamin@python.org>
Date: Mon, 16 Feb 2009 21:23:04 +0000 (+0000)
Subject: PyList_Append() can fail
X-Git-Tag: v2.7a1~2011
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a7b0c12152e6268bb09b462f2a0fe52178ee6065;p=python

PyList_Append() can fail
---

diff --git a/Modules/itertoolsmodule.c b/Modules/itertoolsmodule.c
index f42232db69..fefcbfb230 100644
--- a/Modules/itertoolsmodule.c
+++ b/Modules/itertoolsmodule.c
@@ -745,8 +745,10 @@ cycle_next(cycleobject *lz)
 	while (1) {
 		item = PyIter_Next(lz->it);
 		if (item != NULL) {
-			if (!lz->firstpass)
-				PyList_Append(lz->saved, item);
+			if (!lz->firstpass && PyList_Append(lz->saved, item)) {
+				Py_DECREF(item);
+				return NULL;
+			}
 			return item;
 		}
 		if (PyErr_Occurred()) {