From: Alexander Barton <alex@barton.de>
Date: Wed, 28 Dec 2011 13:39:47 +0000 (+0100)
Subject: Don't stop mode handling on unknown modes; skip it
X-Git-Tag: rel-19-rc1~90
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a71abfef4b82aace4989db6a4ed3c94d1266b287;p=ngircd

Don't stop mode handling on unknown modes; skip it

Unknown user and channel modes no longer stop the mode parser, but are
simply ignored. Therefore modes after the unknown one are now handled.

This is how ircd2.10/ircd2.11/ircd-seven behave, at least.

Reported by Cahata -- thanks!
---

diff --git a/src/ngircd/irc-mode.c b/src/ngircd/irc-mode.c
index ba44a3ba..d8329b16 100644
--- a/src/ngircd/irc-mode.c
+++ b/src/ngircd/irc-mode.c
@@ -253,7 +253,6 @@ Client_Mode( CLIENT *Client, REQUEST *Req, CLIENT *Origin, CLIENT *Target )
 							set ? '+' : '-',
 							*mode_ptr);
 				x[0] = '\0';
-				goto client_exit;
 			} else {
 				Log(LOG_DEBUG,
 				    "Handling unknown mode \"%c%c\" from \"%s\" for \"%s\" ...",
@@ -278,7 +277,6 @@ Client_Mode( CLIENT *Client, REQUEST *Req, CLIENT *Origin, CLIENT *Target )
 				strlcat(the_modes, x, sizeof(the_modes));
 		}
 	}
-client_exit:
 
 	/* Are there changed modes? */
 	if (the_modes[1]) {
@@ -671,7 +669,6 @@ Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel)
 					Client_ID(Origin),
 					set ? '+' : '-', *mode_ptr);
 				x[0] = '\0';
-				goto chan_exit;
 			} else {
 				Log(LOG_DEBUG,
 				    "Handling unknown mode \"%c%c\" from \"%s\" on %s ...",