From: Neal Norwitz <nnorwitz@gmail.com>
Date: Tue, 2 May 2006 06:23:22 +0000 (+0000)
Subject: Try to fix breakage caused by patch #1479181, r45850
X-Git-Tag: v2.5b1~737
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a6d01cec3ff3b945565653f96141c693af639924;p=python

Try to fix breakage caused by patch #1479181, r45850
---

diff --git a/Lib/subprocess.py b/Lib/subprocess.py
index 4f383147b0..87508ccff2 100644
--- a/Lib/subprocess.py
+++ b/Lib/subprocess.py
@@ -872,7 +872,7 @@ class Popen(object):
             # object do the translation: It is based on stdio, which is
             # impossible to combine with select (unless forcing no
             # buffering).
-            if self.universal_newlines and hasattr(open, 'newlines'):
+            if self.universal_newlines and hasattr(file, 'newlines'):
                 if stdout:
                     stdout = self._translate_newlines(stdout)
                 if stderr:
@@ -1141,7 +1141,7 @@ class Popen(object):
             # object do the translation: It is based on stdio, which is
             # impossible to combine with select (unless forcing no
             # buffering).
-            if self.universal_newlines and hasattr(open, 'newlines'):
+            if self.universal_newlines and hasattr(file, 'newlines'):
                 if stdout:
                     stdout = self._translate_newlines(stdout)
                 if stderr:
diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py
index 88a4baa87d..edf5bd0fd6 100644
--- a/Lib/test/test_subprocess.py
+++ b/Lib/test/test_subprocess.py
@@ -347,7 +347,7 @@ class ProcessTestCase(unittest.TestCase):
                          stdout=subprocess.PIPE,
                          universal_newlines=1)
         stdout = p.stdout.read()
-        if hasattr(p.stdout, 'newlines'):
+        if hasattr(file, 'newlines'):
             # Interpreter with universal newline support
             self.assertEqual(stdout,
                              "line1\nline2\nline3\nline4\nline5\nline6")
@@ -374,7 +374,7 @@ class ProcessTestCase(unittest.TestCase):
                          stdout=subprocess.PIPE, stderr=subprocess.PIPE,
                          universal_newlines=1)
         (stdout, stderr) = p.communicate()
-        if hasattr(stdout, 'newlines'):
+        if hasattr(file, 'newlines'):
             # Interpreter with universal newline support
             self.assertEqual(stdout,
                              "line1\nline2\nline3\nline4\nline5\nline6")