From: Saleem Abdulrasool <compnerd+gitlab@compnerd.org>
Date: Sun, 2 May 2021 16:04:57 +0000 (+0000)
Subject: GVC: export 'gvToolTred'
X-Git-Tag: 2.47.2~29^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a6c3f567b819e041ac0c25e2f9f33ea778dde9d1;p=graphviz

GVC: export 'gvToolTred'
---

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5da55bbc6..4511ddb09 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -21,6 +21,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Uninitialized variable read in delaunay_tri
 - potentially mismatched format string in tclpkg
+- `gvToolTred` is now exported from gvc.dll on Windows mirroring the behavior on
+  Unix platforms.
 
 ## [2.47.1] - 2021-04-17
 
diff --git a/lib/gvc.vcxproj b/lib/gvc.vcxproj
index 32ebc71d2..708d8b4b0 100644
--- a/lib/gvc.vcxproj
+++ b/lib/gvc.vcxproj
@@ -190,6 +190,7 @@ awk -f $(SolutionDir)awk\colortbl.awk color_lib &gt; common\colortbl.h</Command>
     <ClCompile Include="gvc\gvplugin.c" />
     <ClCompile Include="gvc\gvrender.c" />
     <ClCompile Include="gvc\gvtextlayout.c" />
+    <ClCompile Include="gvc\gvtool_tred.c" />
     <ClCompile Include="gvc\gvusershape.c" />
     <ClCompile Include="label\index.c" />
     <ClCompile Include="label\node.c" />
diff --git a/lib/gvc.vcxproj.filters b/lib/gvc.vcxproj.filters
index 85cb0334a..36bfe21a4 100644
--- a/lib/gvc.vcxproj.filters
+++ b/lib/gvc.vcxproj.filters
@@ -188,6 +188,9 @@
     <ClCompile Include="gvc\gvtextlayout.c">
       <Filter>Source Files</Filter>
     </ClCompile>
+    <ClCompile Include="gvc\gvtool_tred.c">
+      <Filter>Source Files</Filter>
+    </ClCompile>
     <ClCompile Include="gvc\gvusershape.c">
       <Filter>Source Files</Filter>
     </ClCompile>
diff --git a/lib/gvc/gvc.def b/lib/gvc/gvc.def
index 8aafb6828..53dfaf835 100644
--- a/lib/gvc/gvc.def
+++ b/lib/gvc/gvc.def
@@ -157,6 +157,7 @@ gvFreeRenderData
 gvRenderFilename    
 gvRenderJobs    
 gvToggle    
+gvToolTred
 gvusershape_file_access    
 gvusershape_file_release    
 gvwrite    
diff --git a/rtest/2057.c b/rtest/2057.c
new file mode 100644
index 000000000..dea7c095e
--- /dev/null
+++ b/rtest/2057.c
@@ -0,0 +1,9 @@
+// see test_regression.py:test_2057
+
+#include <stdio.h>
+#include <graphviz/gvc.h>
+
+int main(void) {
+  printf("%p\n", gvToolTred);
+  return 0;
+}
diff --git a/rtest/test_regression.py b/rtest/test_regression.py
index 2f2fc87c3..84d5b295a 100644
--- a/rtest/test_regression.py
+++ b/rtest/test_regression.py
@@ -769,6 +769,25 @@ def test_1931():
   assert "line 3\nline 4" in xdot
   assert "line 5\nline 6" in xdot
 
+def test_2057():
+  """
+  gvToolTred should be usable by user code
+  https://gitlab.com/graphviz/graphviz/-/issues/2057
+  """
+
+  # FIXME: Remove skip when
+  # https://gitlab.com/graphviz/graphviz/-/issues/1777 is fixed
+  if os.getenv("build_system") == "msbuild":
+    pytest.skip("Windows MSBuild release does not contain any header files (#1777)")
+
+  # find co-located test source
+  c_src = (Path(__file__).parent / "2057.c").resolve()
+  assert c_src.exists(), "missing test case"
+
+  # run the test
+  ret, _, _ = run_c(c_src, link=["gvc"])
+  assert ret == 0
+
 def test_package_version():
   """
   The graphviz_version.h header should define a non-empty PACKAGE_VERSION