From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed, 28 May 2014 19:42:04 +0000 (-0400)
Subject: Fix bogus %name-prefix option syntax in all our Bison files.
X-Git-Tag: REL9_0_18~27
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a670f5ed1ad0a472c4981b821bfcfc2c9dd0c2fd;p=postgresql

Fix bogus %name-prefix option syntax in all our Bison files.

%name-prefix doesn't use an "=" sign according to the Bison docs, but it
silently accepted one anyway, until Bison 3.0.  This was originally a
typo of mine in commit 012abebab1bc72043f3f670bf32e91ae4ee04bd2, and we
seem to have slavishly copied the error into all the other grammar files.

Per report from Vik Fearing; analysis by Peter Eisentraut.

Back-patch to all active branches, since somebody might try to build
a back branch with up-to-date tools.
---

diff --git a/contrib/cube/cubeparse.y b/contrib/cube/cubeparse.y
index 53894d9d75..a049c2081d 100644
--- a/contrib/cube/cubeparse.y
+++ b/contrib/cube/cubeparse.y
@@ -39,7 +39,7 @@ static NDBOX * write_point_as_box(char *s, int dim);
 /* BISON Declarations */
 %parse-param {NDBOX **result}
 %expect 0
-%name-prefix="cube_yy"
+%name-prefix "cube_yy"
 
 %token CUBEFLOAT O_PAREN C_PAREN O_BRACKET C_BRACKET COMMA
 %start box
diff --git a/contrib/seg/segparse.y b/contrib/seg/segparse.y
index 9aaa9e9ab2..c6f85c174b 100644
--- a/contrib/seg/segparse.y
+++ b/contrib/seg/segparse.y
@@ -42,7 +42,7 @@
 /* BISON Declarations */
 %parse-param {SEG *result}
 %expect 0
-%name-prefix="seg_yy"
+%name-prefix "seg_yy"
 
 %union {
   struct BND {
diff --git a/src/backend/bootstrap/bootparse.y b/src/backend/bootstrap/bootparse.y
index 72ebe7046b..948c582df5 100644
--- a/src/backend/bootstrap/bootparse.y
+++ b/src/backend/bootstrap/bootparse.y
@@ -93,7 +93,7 @@ static int num_columns_read = 0;
 %}
 
 %expect 0
-%name-prefix="boot_yy"
+%name-prefix "boot_yy"
 
 %union
 {
diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
index 758cf6fdf8..4a62131336 100644
--- a/src/backend/parser/gram.y
+++ b/src/backend/parser/gram.y
@@ -134,7 +134,7 @@ static TypeName *TableFuncTypeName(List *columns);
 
 %pure-parser
 %expect 0
-%name-prefix="base_yy"
+%name-prefix "base_yy"
 %locations
 
 %parse-param {core_yyscan_t yyscanner}
diff --git a/src/interfaces/ecpg/preproc/ecpg.header b/src/interfaces/ecpg/preproc/ecpg.header
index 3398f004cf..4683d60ac3 100644
--- a/src/interfaces/ecpg/preproc/ecpg.header
+++ b/src/interfaces/ecpg/preproc/ecpg.header
@@ -464,7 +464,7 @@ add_typedef(char *name, char * dimension, char * length, enum ECPGttype type_enu
 %}
 
 %expect 0
-%name-prefix="base_yy"
+%name-prefix "base_yy"
 %locations
 
 %union {
diff --git a/src/pl/plpgsql/src/gram.y b/src/pl/plpgsql/src/gram.y
index 60abdc2589..968f6d8fff 100644
--- a/src/pl/plpgsql/src/gram.y
+++ b/src/pl/plpgsql/src/gram.y
@@ -108,7 +108,7 @@ static	List			*read_raise_options(void);
 %}
 
 %expect 0
-%name-prefix="plpgsql_yy"
+%name-prefix "plpgsql_yy"
 %locations
 
 %union {