From: Christopher Jones Date: Fri, 6 Nov 2015 15:14:18 +0000 (+1100) Subject: Fix compile warnings about comparison of unsigned expression always being true X-Git-Tag: php-5.6.16RC1~4 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a57b2053832fc0136d6b894148d0d20c0d9d90df;p=php Fix compile warnings about comparison of unsigned expression always being true --- diff --git a/ext/oci8/oci8_interface.c b/ext/oci8/oci8_interface.c index bb7212290d..817b8dbf8b 100644 --- a/ext/oci8/oci8_interface.c +++ b/ext/oci8/oci8_interface.c @@ -373,7 +373,7 @@ PHP_FUNCTION(oci_lob_eof) PHP_OCI_ZVAL_TO_DESCRIPTOR(*tmp, descriptor); - if (!php_oci_lob_get_length(descriptor, &lob_length TSRMLS_CC) && lob_length >= 0) { + if (!php_oci_lob_get_length(descriptor, &lob_length TSRMLS_CC)) { if (lob_length == descriptor->lob_current_position) { RETURN_TRUE; } diff --git a/ext/oci8/oci8_lob.c b/ext/oci8/oci8_lob.c index ca08373ff2..079e0a6a8f 100644 --- a/ext/oci8/oci8_lob.c +++ b/ext/oci8/oci8_lob.c @@ -417,10 +417,6 @@ int php_oci_lob_write (php_oci_descriptor *descriptor, ub4 offset, char *data, i return 0; } - if (offset < 0) { - offset = 0; - } - if (offset > descriptor->lob_current_position) { offset = descriptor->lob_current_position; }