From: Victor Stinner <victor.stinner@gmail.com>
Date: Fri, 13 Oct 2017 20:47:49 +0000 (-0700)
Subject: bpo-31676: Fix test_imp.test_load_source() side effect (#3871)
X-Git-Tag: v3.7.0a2~15
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a505ecdc5013cd8f930aacc1ec4fb2afa62d3853;p=python

bpo-31676: Fix test_imp.test_load_source() side effect (#3871)

test_load_source() now replaces the current __name__ module with a
temporary module to prevent side effects.
---

diff --git a/Lib/test/test_imp.py b/Lib/test/test_imp.py
index 51bec50cc2..1ef0accf0f 100644
--- a/Lib/test/test_imp.py
+++ b/Lib/test/test_imp.py
@@ -310,8 +310,13 @@ class ImportTests(unittest.TestCase):
         loader.get_data(imp.__file__)  # Will need to create a newly opened file
 
     def test_load_source(self):
-        with self.assertRaisesRegex(ValueError, 'embedded null'):
-            imp.load_source(__name__, __file__ + "\0")
+        # Create a temporary module since load_source(name) modifies
+        # sys.modules[name] attributes like __loader___
+        modname = f"tmp{__name__}"
+        mod = type(sys.modules[__name__])(modname)
+        with support.swap_item(sys.modules, modname, mod):
+            with self.assertRaisesRegex(ValueError, 'embedded null'):
+                imp.load_source(modname, __file__ + "\0")
 
     @support.cpython_only
     def test_issue31315(self):