From: Alp Toker Date: Fri, 16 May 2014 17:23:01 +0000 (+0000) Subject: Rename SourceManager::createFileIDForMemBuffer() X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a4ba244cd4729b72b7b0be67493ea36618545790;p=clang Rename SourceManager::createFileIDForMemBuffer() It makes more sense to just overload createFileID(). Gardening only. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@209002 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/include/clang/Basic/SourceManager.h b/include/clang/Basic/SourceManager.h index df38f75adb..31f1b8f8bb 100644 --- a/include/clang/Basic/SourceManager.h +++ b/include/clang/Basic/SourceManager.h @@ -754,7 +754,7 @@ public: FileID createMainFileIDForMemBuffer(const llvm::MemoryBuffer *Buffer, SrcMgr::CharacteristicKind Kind = SrcMgr::C_User) { assert(MainFileID.isInvalid() && "MainFileID already set!"); - MainFileID = createFileIDForMemBuffer(Buffer, Kind); + MainFileID = createFileID(Buffer, Kind); return MainFileID; } @@ -810,10 +810,10 @@ public: /// /// This does no caching of the buffer and takes ownership of the /// MemoryBuffer, so only pass a MemoryBuffer to this once. - FileID createFileIDForMemBuffer(const llvm::MemoryBuffer *Buffer, + FileID createFileID(const llvm::MemoryBuffer *Buffer, SrcMgr::CharacteristicKind FileCharacter = SrcMgr::C_User, - int LoadedID = 0, unsigned LoadedOffset = 0, - SourceLocation IncludeLoc = SourceLocation()) { + int LoadedID = 0, unsigned LoadedOffset = 0, + SourceLocation IncludeLoc = SourceLocation()) { return createFileID(createMemBufferContentCache(Buffer), IncludeLoc, FileCharacter, LoadedID, LoadedOffset); } diff --git a/lib/AST/ASTImporter.cpp b/lib/AST/ASTImporter.cpp index e996c7eff2..b180326508 100644 --- a/lib/AST/ASTImporter.cpp +++ b/lib/AST/ASTImporter.cpp @@ -4923,8 +4923,7 @@ FileID ASTImporter::Import(FileID FromID) { llvm::MemoryBuffer *ToBuf = llvm::MemoryBuffer::getMemBufferCopy(FromBuf->getBuffer(), FromBuf->getBufferIdentifier()); - ToID = ToSM.createFileIDForMemBuffer(ToBuf, - FromSLoc.getFile().getFileCharacteristic()); + ToID = ToSM.createFileID(ToBuf, FromSLoc.getFile().getFileCharacteristic()); } diff --git a/lib/CodeGen/CodeGenAction.cpp b/lib/CodeGen/CodeGenAction.cpp index b0c5fa12e6..9b5b9f59ab 100644 --- a/lib/CodeGen/CodeGenAction.cpp +++ b/lib/CodeGen/CodeGenAction.cpp @@ -249,7 +249,7 @@ static FullSourceLoc ConvertBackendLocation(const llvm::SMDiagnostic &D, llvm::MemoryBuffer *CBuf = llvm::MemoryBuffer::getMemBufferCopy(LBuf->getBuffer(), LBuf->getBufferIdentifier()); - FileID FID = CSM.createFileIDForMemBuffer(CBuf); + FileID FID = CSM.createFileID(CBuf); // Translate the offset into the file. unsigned Offset = D.getLoc().getPointer() - LBuf->getBufferStart(); diff --git a/lib/Lex/Preprocessor.cpp b/lib/Lex/Preprocessor.cpp index d263e7d2a0..fec0d5bd73 100644 --- a/lib/Lex/Preprocessor.cpp +++ b/lib/Lex/Preprocessor.cpp @@ -479,7 +479,7 @@ void Preprocessor::EnterMainSourceFile() { llvm::MemoryBuffer *SB = llvm::MemoryBuffer::getMemBufferCopy(Predefines, ""); assert(SB && "Cannot create predefined source buffer"); - FileID FID = SourceMgr.createFileIDForMemBuffer(SB); + FileID FID = SourceMgr.createFileID(SB); assert(!FID.isInvalid() && "Could not create FileID for predefines?"); setPredefinesFileID(FID); diff --git a/lib/Lex/ScratchBuffer.cpp b/lib/Lex/ScratchBuffer.cpp index 3d363fa4b4..984a0c154a 100644 --- a/lib/Lex/ScratchBuffer.cpp +++ b/lib/Lex/ScratchBuffer.cpp @@ -65,7 +65,7 @@ void ScratchBuffer::AllocScratchBuffer(unsigned RequestLen) { llvm::MemoryBuffer *Buf = llvm::MemoryBuffer::getNewMemBuffer(RequestLen, ""); - FileID FID = SourceMgr.createFileIDForMemBuffer(Buf); + FileID FID = SourceMgr.createFileID(Buf); BufferStartLoc = SourceMgr.getLocForStartOfFile(FID); CurBuffer = const_cast(Buf->getBufferStart()); BytesUsed = 1; diff --git a/lib/Serialization/ASTReader.cpp b/lib/Serialization/ASTReader.cpp index bd2174046b..ea7f953b9f 100644 --- a/lib/Serialization/ASTReader.cpp +++ b/lib/Serialization/ASTReader.cpp @@ -1249,8 +1249,8 @@ bool ASTReader::ReadSLocEntry(int ID) { llvm::MemoryBuffer *Buffer = llvm::MemoryBuffer::getMemBuffer(Blob.drop_back(1), Name); - SourceMgr.createFileIDForMemBuffer(Buffer, FileCharacter, ID, - BaseOffset + Offset, IncludeLoc); + SourceMgr.createFileID(Buffer, FileCharacter, ID, BaseOffset + Offset, + IncludeLoc); break; } diff --git a/unittests/AST/CommentLexer.cpp b/unittests/AST/CommentLexer.cpp index fc0fd77275..cb8de27180 100644 --- a/unittests/AST/CommentLexer.cpp +++ b/unittests/AST/CommentLexer.cpp @@ -61,7 +61,7 @@ protected: void CommentLexerTest::lexString(const char *Source, std::vector &Toks) { MemoryBuffer *Buf = MemoryBuffer::getMemBuffer(Source); - FileID File = SourceMgr.createFileIDForMemBuffer(Buf); + FileID File = SourceMgr.createFileID(Buf); SourceLocation Begin = SourceMgr.getLocForStartOfFile(File); Lexer L(Allocator, Diags, Traits, Begin, Source, Source + strlen(Source)); diff --git a/unittests/AST/CommentParser.cpp b/unittests/AST/CommentParser.cpp index c72aef107f..0064078d86 100644 --- a/unittests/AST/CommentParser.cpp +++ b/unittests/AST/CommentParser.cpp @@ -55,7 +55,7 @@ protected: FullComment *CommentParserTest::parseString(const char *Source) { MemoryBuffer *Buf = MemoryBuffer::getMemBuffer(Source); - FileID File = SourceMgr.createFileIDForMemBuffer(Buf); + FileID File = SourceMgr.createFileID(Buf); SourceLocation Begin = SourceMgr.getLocForStartOfFile(File); Lexer L(Allocator, Diags, Traits, Begin, Source, Source + strlen(Source));