From: Dmitry Stogov <dmitry@zend.com>
Date: Tue, 10 Dec 2013 12:02:59 +0000 (+0400)
Subject: Revered func_get_args() changes, because they were not completly transparent and... 
X-Git-Tag: POST_64BIT_BRANCH_MERGE^2~109^2~18^2~338^2~3^2^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a46f644b3ac4abe7577165de4e4850e5c2c88227;p=php

Revered func_get_args() changes, because they were not completly transparent and broke some tricky PHP code that worked because of luck before php-5.5.6 (see Bug #66107). The changes are going to be kept in PHP-5.6.
---

diff --git a/Zend/zend_builtin_functions.c b/Zend/zend_builtin_functions.c
index 6cbe0bc687..1ad64e74ea 100644
--- a/Zend/zend_builtin_functions.c
+++ b/Zend/zend_builtin_functions.c
@@ -461,17 +461,12 @@ ZEND_FUNCTION(func_get_args)
 
 	array_init_size(return_value, arg_count);
 	for (i=0; i<arg_count; i++) {
-		zval *element, *arg;
+		zval *element;
 
-		arg = *((zval **) (p-(arg_count-i)));
-		if (!Z_ISREF_P(arg)) {
-			element = arg;
-			Z_ADDREF_P(element);
-		} else {
-			ALLOC_ZVAL(element);
-			INIT_PZVAL_COPY(element, arg);
-			zval_copy_ctor(element);
-	    }
+		ALLOC_ZVAL(element);
+		*element = **((zval **) (p-(arg_count-i)));
+		zval_copy_ctor(element);
+		INIT_PZVAL(element);
 		zend_hash_next_index_insert(return_value->value.ht, &element, sizeof(zval *), NULL);
 	}
 }