From: PatR Date: Fri, 30 Jun 2017 23:31:54 +0000 (-0700) Subject: fixes36.1 update: #H4725 - repeated shortcut keys X-Git-Tag: NetHack-3.6.1_RC01~460 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a45ac9955fee7f18346b07d24a5bcb4d5d76eb7a;p=nethack fixes36.1 update: #H4725 - repeated shortcut keys Mark an old 'unconfirmed' bug as 'fixed'. The report was for win32gui and I can't reproduce the problem or verify that it's gone, but I'm sure enough about the cause and long-ago fix to put #H4725 to rest.... Report was that the menu for the name-from-discoveries-list command was reusing a set of punctuation characters for each class of objects. The key was that '!' was always first, and it is (' ' + 1) so the core bug of erroneously specifying space for a selector on object class header/separator lines was being used as the start of the selector sequence. (Report that led to the fix was that typing space on that menu always made it finish instead of advance to the next page.) --- diff --git a/doc/fixes36.1 b/doc/fixes36.1 index 7c70a7ab3..d47896d54 100644 --- a/doc/fixes36.1 +++ b/doc/fixes36.1 @@ -493,6 +493,9 @@ unix: Makefile.{src,utl} ignored CPPFLAGS which is expanded by the default .c win32gui: getversionstring() was overflowing the provided Help About buffer win32gui: guard against buffer overflow in in mswin_getlin() win32gui: handle menu_color attribute +win32gui: name-from-discoveries list menu selector characters were punctuation + instead of letters, repeated for each class; caused by the core bug + of erroneously specifying space as a selector for class header lines MacOSX: initial binary release was built from out of date source code that had 'BETA' and 'DEBUG' inappropriately enabled MacOSX: force TIMED_DELAY build option on so that 'runmode' run-time option