From: nhmall Date: Wed, 27 Nov 2019 22:19:55 +0000 (-0500) Subject: number pad changes from pull request #247 X-Git-Tag: NetHack-3.6.3_Released~27 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a351f904761812f1db80c0fb549b6bbd219841cd;p=nethack number pad changes from pull request #247 Below is the accompanying text from the pull request on GitHub https://github.com/NetHack/NetHack/pull/247: > This fixes the issue brought up in https://www.reddit.com/r/nethack/comments/dv3pae/curses_and_the_numberpad/?st=k3hgply6&sh=dbc2bf7d . > > I don't know why the "regular" (tty) method doesn't seem to work for him, > but I'm going to chalk it up to a PDCurses oddity. What I do know, however, > is that the alternate method I added a year ago or maybe longer, that allows > numpad usage even with number_pad:0 (to retain the default keybindings in case > an user is used to them, while keeping number pad behaviour making sense, > similar to NetHack4+friends) was only partially implemented, for some reason. > This adds the rest of the keys, meaning that this means of key interpretation > should be more realible. KEY_A2/B1/B3/C2 are not standard keys in the Curses > documentation, and is thus behind an ifdef -- but PDCurses, amongst other > implementations, makes use of them. > > As a side effect, Home/End/PgUp/PgDn are now interpreted as diagonal movement, > since some terminals interpret number_pad keys that way. I do not consider this > a problem since they went unused in normal gameplay anyway (This does not > interfere with menus or similar). Closes #247 --- diff --git a/doc/fixes36.3 b/doc/fixes36.3 index 4dd283b4d..2573be3bc 100644 --- a/doc/fixes36.3 +++ b/doc/fixes36.3 @@ -479,6 +479,7 @@ add a couple of engraving suggestions in pull request #79 chasonr's faster method to write characters to msdos VGA in pull request #220 chasonr's msdos Makefile.gcc pdcurses build changes in pull request #243 autopickup exception priority change in pull request #226 +FIQ's curses (PDCurses) number pad changes in pull request #247 Code Cleanup and Reorganization