From: Martin v. Löwis <martin@v.loewis.de>
Date: Sat, 7 Oct 2000 12:10:28 +0000 (+0000)
Subject: Record bugs found when comparing the module with DOM Core Level 2.
X-Git-Tag: v2.0c1~51
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a2fda0dfaba89162e11b969622663ae4c00fa7c1;p=python

Record bugs found when comparing the module with DOM Core Level 2.
---

diff --git a/Lib/xml/dom/minidom.py b/Lib/xml/dom/minidom.py
index 7d610c6caf..b2b6e7db0a 100644
--- a/Lib/xml/dom/minidom.py
+++ b/Lib/xml/dom/minidom.py
@@ -250,7 +250,7 @@ class AttributeList:
         del self._attrs[node.name]
         del self._attrsNS[(node.namespaceURI, node.localName)]
 
-class Element( Node ):
+class Element(Node):
     nodeType = Node.ELEMENT_NODE
 
     def __init__(self, tagName, namespaceURI="", prefix="",
@@ -287,6 +287,7 @@ class Element( Node ):
         attr = Attr(qualifiedName, namespaceURI, localname, prefix)
         attr.__dict__["value"] = attr.__dict__["nodeValue"] = value
         self.setAttributeNode(attr)
+        # FIXME: return original node if something changed.
 
     def getAttributeNode(self, attrname):
         return self._attrs.get(attrname)
@@ -300,6 +301,7 @@ class Element( Node ):
             old.unlink()
         self._attrs[attr.name] = attr
         self._attrsNS[(attr.namespaceURI, attr.localName)] = attr
+        # FIXME: return old value if something changed
 
     def removeAttribute(self, name):
         attr = self._attrs[name]
@@ -323,6 +325,7 @@ class Element( Node ):
     def __repr__(self):
         return "<DOM Element: %s at %s>" % (self.tagName, id(self))
 
+    # undocumented
     def writexml(self, writer):
         writer.write("<" + self.tagName)