From: Daniel Dunbar <daniel@zuster.org>
Date: Fri, 10 Apr 2009 18:32:59 +0000 (+0000)
Subject: Driver: CCC_ADD_ARGS could end up using dangling pointers.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a1e2fd9b580ae583b91d3288d59c00ca9f6a56b8;p=clang

Driver: CCC_ADD_ARGS could end up using dangling pointers.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@68805 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Driver/Driver.cpp b/lib/Driver/Driver.cpp
index f9a82ff78d..8768629625 100644
--- a/lib/Driver/Driver.cpp
+++ b/lib/Driver/Driver.cpp
@@ -109,8 +109,6 @@ Compilation *Driver::BuildCompilation(int argc, const char **argv) {
 
   // FIXME: What are we going to do with -V and -b?
 
-  // FIXME: Handle CCC_ADD_ARGS.
-
   // FIXME: This stuff needs to go into the Compilation, not the
   // driver.
   bool CCCPrintOptions = false, CCCPrintActions = false;
diff --git a/tools/driver/driver.cpp b/tools/driver/driver.cpp
index 3c75bb0d18..94fcf7cc56 100644
--- a/tools/driver/driver.cpp
+++ b/tools/driver/driver.cpp
@@ -86,8 +86,8 @@ int main(int argc, const char **argv) {
   llvm::OwningPtr<Compilation> C;
 
   // Handle CCC_ADD_ARGS, a comma separated list of extra arguments.
+  std::set<std::string> SavedStrings;
   if (const char *Cur = ::getenv("CCC_ADD_ARGS")) {
-    std::set<std::string> SavedStrings;
     std::vector<const char*> StringPointers;
 
     // FIXME: Driver shouldn't take extra initial argument.