From: Felipe Pena <felipensp@gmail.com>
Date: Tue, 19 Nov 2013 22:13:51 +0000 (-0200)
Subject: - Removed unnecessary check and allocation
X-Git-Tag: php-5.6.0alpha1~110^2~189^2~1
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a1adc8124e903f26f51ef8f69b37dc8e1d4c5a52;p=php

- Removed unnecessary check and allocation
---

diff --git a/phpdbg_cmd.c b/phpdbg_cmd.c
index db7774d7e0..d1767b00fb 100644
--- a/phpdbg_cmd.c
+++ b/phpdbg_cmd.c
@@ -247,29 +247,23 @@ phpdbg_input_t *phpdbg_read_input(TSRMLS_D) /* {{{ */
 
 		buffer->string = phpdbg_trim(cmd, strlen(cmd), &buffer->length);
 
-		if (buffer->string) {
-			/* temporary, when we switch to argv/argc handling
-				will be unnecessary */
-			char *store = (char*) estrdup(buffer->string);
+		/* store constant pointer to start of buffer */
+		buffer->start = (char* const*) buffer->string;
 
-			/* store constant pointer to start of buffer */
-			buffer->start = (char* const*) buffer->string;
+		buffer->argv = phpdbg_read_argv(
+			buffer->string, &buffer->argc TSRMLS_CC);
 
-			buffer->argv = phpdbg_read_argv(
-				store, &buffer->argc TSRMLS_CC);
+#ifdef PHPDBG_DEBUG
+		if (buffer->argc) {
+			int arg = 0;
 
-			if (buffer->argc) {
-				int arg = 0;
-
-				while (arg < buffer->argc) {
-					phpdbg_debug(
-						"argv %d=%s", arg, buffer->argv[arg]->string);
-					arg++;
-				}
+			while (arg < buffer->argc) {
+				phpdbg_debug(
+					"argv %d=%s", arg, buffer->argv[arg]->string);
+				arg++;
 			}
-
-			efree(store);
 		}
+#endif
 
 #ifdef HAVE_LIBREADLINE
 		if (cmd) {