From: Ted Kremenek <kremenek@apple.com>
Date: Wed, 16 Dec 2009 06:03:24 +0000 (+0000)
Subject: Teach OSAtomicChecker that a FunctionDecl's name isn't always a simple IdentifierInfo*.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a0f7727abd351646a4c7efe38c563a894bcf5403;p=clang

Teach OSAtomicChecker that a FunctionDecl's name isn't always a simple IdentifierInfo*.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@91511 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Analysis/OSAtomicChecker.cpp b/lib/Analysis/OSAtomicChecker.cpp
index 5a89345883..cf16796b1b 100644
--- a/lib/Analysis/OSAtomicChecker.cpp
+++ b/lib/Analysis/OSAtomicChecker.cpp
@@ -44,11 +44,15 @@ bool OSAtomicChecker::EvalCallExpr(CheckerContext &C,const CallExpr *CE) {
   if (!FD)
     return false;
 
-  const char *FName = FD->getNameAsCString();
+  const IdentifierInfo *II = FD->getIdentifier();
+  if (!II)
+    return false;
+  
+  llvm::StringRef FName(II->getName());
 
   // Check for compare and swap.
-  if (strncmp(FName, "OSAtomicCompareAndSwap", 22) == 0 ||
-      strncmp(FName, "objc_atomicCompareAndSwap", 25) == 0)
+  if (FName.startswith("OSAtomicCompareAndSwap") ||
+      FName.startswith("objc_atomicCompareAndSwap"))
     return EvalOSAtomicCompareAndSwap(C, CE);
 
   // FIXME: Other atomics.