From: Todd C. Miller <Todd.Miller@courtesan.com>
Date: Thu, 5 May 2016 21:12:37 +0000 (-0600)
Subject: In fill_args(), check for "arg_size == 0" instead of
X-Git-Tag: SUDO_1_8_17^2~113
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a09e45d339c79deb074a5a38b54a2c9317d1acf5;p=sudo

In fill_args(), check for "arg_size == 0" instead of
"sudoerslval.command.args == NULL" since the latter leads Coverity
to imply that sudoerslval.command.args could be NULL later on.
Coverity CID 104093.
---

diff --git a/plugins/sudoers/toke_util.c b/plugins/sudoers/toke_util.c
index be46782f9..01b4fe110 100644
--- a/plugins/sudoers/toke_util.c
+++ b/plugins/sudoers/toke_util.c
@@ -131,7 +131,7 @@ fill_args(const char *s, size_t len, int addspace)
     char *p;
     debug_decl(fill_args, SUDOERS_DEBUG_PARSER)
 
-    if (sudoerslval.command.args == NULL) {
+    if (arg_size == 0) {
 	addspace = 0;
 	new_len = len;
     } else