From: Bruce Momjian <bruce@momjian.us>
Date: Wed, 25 Jun 2003 04:08:19 +0000 (+0000)
Subject: If they're not, the below causes problems, as the foreign key is added
X-Git-Tag: REL7_4_BETA1~317
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=a09ccc70dd78b33271b06a6c250f7578aa4e16a1;p=postgresql

If they're not, the below causes problems, as the foreign key is added
after the CHECK.  Cluster depends on the index name, so I thought it
wise to ensure all names are available, rather than leaving off the
CONSTRAINT "$n" portion for internally named constraints.

CREATE TABLE jkey (col integer primary key);
CREATE TABLE j (col integer REFERENCES jkey);
ALTER TABLE j ADD CHECK(col > 5);

This is a problem in 7.3 series as well as -Tip.

Rod Taylor <rbt@rbt.ca>
---

diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index 4879620f12..c7e30d7c71 100644
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -12,7 +12,7 @@
  *	by PostgreSQL
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.334 2003/06/25 03:56:31 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.335 2003/06/25 04:08:19 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -5347,8 +5347,7 @@ dumpOneTable(Archive *fout, TableInfo *tbinfo, TableInfo *g_tblinfo)
 				if (actual_atts + j > 0)
 					appendPQExpBuffer(q, ",\n    ");
 
-				if (name[0] != '$')
-					appendPQExpBuffer(q, "CONSTRAINT %s ",
+				appendPQExpBuffer(q, "CONSTRAINT %s ",
 									  fmtId(name));
 				appendPQExpBuffer(q, "%s", expr);
 			}