From: Nick Mathewson <nickm@torproject.org>
Date: Tue, 14 Jul 2009 19:19:45 +0000 (+0000)
Subject: Include disabled methods in event_get_supported_methods() output.
X-Git-Tag: release-2.0.3-alpha~183
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=9fcd84d196205e3eb6dcd0477005cb04974e703f;p=libevent

Include disabled methods in event_get_supported_methods() output.

Previously, events that were disabled using EVENT_NO* were left out of
event_get_supported_methods().  This was wrong, broke unit tests
(under some circumstances) and left the user with no good way to tell
which methods were actually compiled in.

Fixes bug 2821015.

svn:r1344
---

diff --git a/ChangeLog b/ChangeLog
index 27a6a571..2ffe32d7 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -43,7 +43,7 @@ Changes in 2.0.2-alpha:
  o Mitigate a race condition when using socket bufferevents in multiple threads.
  o Use AC_SEARCH_LIBS, not AC_CHECK_LIB to avoid needless library use.
  o Do not allow event_del(ev) to return while that event's callback is executing in another thread.  This fixes a nasty race condition.
-
+ o event_get_supported_methods() now lists methods that have been disabled with the EVENT_NO* environment options.
 
 Changes in 2.0.1-alpha:
  o free minheap on event_base_free(); from Christopher Layne
diff --git a/event.c b/event.c
index f8bc5801..ce325aff 100644
--- a/event.c
+++ b/event.c
@@ -457,8 +457,6 @@ event_get_supported_methods(void)
 
 	/* populate the array with the supported methods */
 	for (k = 0, i = 0; eventops[k] != NULL; ++k) {
-		if (event_is_method_disabled(eventops[k]->name))
-			continue;
 		tmp[i++] = eventops[k]->name;
 	}
 	tmp[i] = NULL;