From: Stef Walter <stef@thewalter.net>
Date: Mon, 8 Jul 2013 14:30:52 +0000 (+0200)
Subject: asn1: In p11_asn1_read() allocate an extra null terminator
X-Git-Tag: 0.19.2~31
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=9f7c426d5a6bfb0e60895a690ed835c47e04cb4e;p=p11-kit

asn1: In p11_asn1_read() allocate an extra null terminator

As a courtesy for callers.
---

diff --git a/trust/asn1.c b/trust/asn1.c
index fcd8e1c..653d816 100644
--- a/trust/asn1.c
+++ b/trust/asn1.c
@@ -197,7 +197,7 @@ p11_asn1_read (node_asn *asn,
                const char *field,
                size_t *length)
 {
-	void *value;
+	unsigned char *value;
 	int len;
 	int ret;
 
@@ -212,12 +212,15 @@ p11_asn1_read (node_asn *asn,
 
 	return_val_if_fail (ret == ASN1_MEM_ERROR, NULL);
 
-	value = malloc (len);
+	value = malloc (len + 1);
 	return_val_if_fail (value != NULL, NULL);
 
 	ret = asn1_read_value (asn, field, value, &len);
 	return_val_if_fail (ret == ASN1_SUCCESS, NULL);
 
+	/* Courtesy zero terminated */
+	value[len] = '\0';
+
 	*length = len;
 	return value;
 }