From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Date: Sat, 31 Mar 2018 23:41:28 +0000 (-0700) Subject: bpo-33132: Fix more reference counting issues in the compiler. (GH-6323) X-Git-Tag: v3.7.0b4~90 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=9e96e7b24e4d3ff4dce4f24c4e469cd5460712c9;p=python bpo-33132: Fix more reference counting issues in the compiler. (GH-6323) (cherry picked from commit aa8e51f5ebb2a71c76059f050de01fc3c985376a) Co-authored-by: Serhiy Storchaka --- diff --git a/Python/compile.c b/Python/compile.c index 03b4826b76..d4245e2f4e 100644 --- a/Python/compile.c +++ b/Python/compile.c @@ -2742,8 +2742,7 @@ compiler_import_as(struct compiler *c, identifier name, identifier asname) attr = PyUnicode_Substring(name, pos, (dot != -1) ? dot : len); if (!attr) return 0; - ADDOP_O(c, IMPORT_FROM, attr, names); - Py_DECREF(attr); + ADDOP_N(c, IMPORT_FROM, attr, names); if (dot == -1) { break; } @@ -3207,8 +3206,7 @@ compiler_nameop(struct compiler *c, identifier name, expr_context_ty ctx) "param invalid for local variable"); return 0; } - ADDOP_O(c, op, mangled, varnames); - Py_DECREF(mangled); + ADDOP_N(c, op, mangled, varnames); return 1; case OP_GLOBAL: switch (ctx) {