From: Gregory P. Smith <greg@mad-scientist.com>
Date: Sat, 3 May 2008 07:12:23 +0000 (+0000)
Subject: Backport r61468 from trunk: Improves the text of the IOError raised
X-Git-Tag: v2.5.3c1~99
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=9e6649f8ee278d0528cb76462b91ee29ee68af19;p=python

Backport r61468 from trunk: Improves the text of the IOError raised
when open() returns EINVAL.  See issue2158.
---

diff --git a/Objects/fileobject.c b/Objects/fileobject.c
index f954e36fa5..565bf5ca2f 100644
--- a/Objects/fileobject.c
+++ b/Objects/fileobject.c
@@ -256,9 +256,12 @@ open_the_file(PyFileObject *f, char *name, char *mode)
 		else if (errno == EINVAL) /* unknown, but not a mode string */
 			errno = ENOENT;
 #endif
+                /* EINVAL is returned when an invalid filename or
+                 * an invalid mode is supplied. */
 		if (errno == EINVAL)
-			PyErr_Format(PyExc_IOError, "invalid mode: %s",
-				     mode);
+			PyErr_Format(PyExc_IOError,
+                                     "invalid filename: %s or mode: %s",
+				     name, mode);
 		else
 			PyErr_SetFromErrnoWithFilenameObject(PyExc_IOError, f->f_name);
 		f = NULL;