From: Zachary Ware <zachary.ware@gmail.com>
Date: Tue, 18 Feb 2014 17:33:18 +0000 (-0600)
Subject: Issue #20609: Fix building 64-bit binaries on 32-bit Windows.
X-Git-Tag: v3.3.5rc1^2~10
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=9e5a9876ad3b666390f77aadfb02b303ff2748bd;p=python

Issue #20609: Fix building 64-bit binaries on 32-bit Windows.
---

diff --git a/Misc/NEWS b/Misc/NEWS
index 4759018d19..211114747f 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -131,6 +131,12 @@ Documentation
 - Issue #20488: Importlib is no longer *an* implementation of import, it's *the*
   implementation.
 
+Build
+-----
+
+- Issue #20609: Restored the ability to build 64-bit Windows binaries on
+  32-bit Windows, which was broken by the change in issue #19788.
+
 
 What's New in Python 3.3.4?
 ===========================
diff --git a/PCbuild/pythoncore.vcxproj b/PCbuild/pythoncore.vcxproj
index 89a63d1015..8b5c42f0ec 100644
--- a/PCbuild/pythoncore.vcxproj
+++ b/PCbuild/pythoncore.vcxproj
@@ -182,7 +182,11 @@
       <BaseAddress>0x1e000000</BaseAddress>
     </Link>
     <PreBuildEvent>
-      <Command>$(KillPythonExe)</Command>
+      <Command>$(KillPythonExe)
+IF %ERRORLEVEL% NEQ 0 (
+    echo kill_python: warning: could not kill running Pythons, exit code %ERRORLEVEL%
+    exit /b 0
+)</Command>
     </PreBuildEvent>
     <PreBuildEvent>
       <Message>Killing any running $(PythonExe) instances...</Message>
@@ -213,7 +217,11 @@
       <BaseAddress>0x1e000000</BaseAddress>
     </Link>
     <PreBuildEvent>
-      <Command>$(KillPythonExe)</Command>
+      <Command>$(KillPythonExe)
+IF %ERRORLEVEL% NEQ 0 (
+    echo kill_python: warning: could not kill running Pythons, exit code %ERRORLEVEL%
+    exit /b 0
+)</Command>
     </PreBuildEvent>
     <PreBuildEvent>
       <Message>Killing any running $(PythonExe) instances...</Message>
@@ -244,7 +252,11 @@
       <BaseAddress>0x1e000000</BaseAddress>
     </Link>
     <PreBuildEvent>
-      <Command>$(KillPythonExe)</Command>
+      <Command>$(KillPythonExe)
+IF %ERRORLEVEL% NEQ 0 (
+    echo kill_python: warning: could not kill running Pythons, exit code %ERRORLEVEL%
+    exit /b 0
+)</Command>
     </PreBuildEvent>
     <PreBuildEvent>
       <Message>Killing any running $(PythonExe) instances...</Message>
@@ -278,7 +290,11 @@
       <BaseAddress>0x1e000000</BaseAddress>
     </Link>
     <PreBuildEvent>
-      <Command>$(KillPythonExe)</Command>
+      <Command>$(KillPythonExe)
+IF %ERRORLEVEL% NEQ 0 (
+    echo kill_python: warning: could not kill running Pythons, exit code %ERRORLEVEL%
+    exit /b 0
+)</Command>
     </PreBuildEvent>
     <PreBuildEvent>
       <Message>Killing any running $(PythonExe) instances...</Message>
@@ -307,7 +323,11 @@
       <BaseAddress>0x1e000000</BaseAddress>
     </Link>
     <PreBuildEvent>
-      <Command>$(KillPythonExe)</Command>
+      <Command>$(KillPythonExe)
+IF %ERRORLEVEL% NEQ 0 (
+    echo kill_python: warning: could not kill running Pythons, exit code %ERRORLEVEL%
+    exit /b 0
+)</Command>
     </PreBuildEvent>
     <PreBuildEvent>
       <Message>Killing any running $(PythonExe) instances...</Message>
@@ -339,7 +359,11 @@
       <TargetMachine>MachineX64</TargetMachine>
     </Link>
     <PreBuildEvent>
-      <Command>$(KillPythonExe)</Command>
+      <Command>$(KillPythonExe)
+IF %ERRORLEVEL% NEQ 0 (
+    echo kill_python: warning: could not kill running Pythons, exit code %ERRORLEVEL%
+    exit /b 0
+)</Command>
     </PreBuildEvent>
     <PreBuildEvent>
       <Message>Killing any running $(PythonExe) instances...</Message>
@@ -368,7 +392,11 @@
       <BaseAddress>0x1e000000</BaseAddress>
     </Link>
     <PreBuildEvent>
-      <Command>$(KillPythonExe)</Command>
+      <Command>$(KillPythonExe)
+IF %ERRORLEVEL% NEQ 0 (
+    echo kill_python: warning: could not kill running Pythons, exit code %ERRORLEVEL%
+    exit /b 0
+)</Command>
     </PreBuildEvent>
     <PreBuildEvent>
       <Message>Killing any running $(PythonExe) instances...</Message>
@@ -400,7 +428,11 @@
       <TargetMachine>MachineX64</TargetMachine>
     </Link>
     <PreBuildEvent>
-      <Command>$(KillPythonExe)</Command>
+      <Command>$(KillPythonExe)
+IF %ERRORLEVEL% NEQ 0 (
+    echo kill_python: warning: could not kill running Pythons, exit code %ERRORLEVEL%
+    exit /b 0
+)</Command>
     </PreBuildEvent>
     <PreBuildEvent>
       <Message>Killing any running $(PythonExe) instances...</Message>