From: Andrei Zmievski Date: Mon, 6 Feb 2006 18:18:41 +0000 (+0000) Subject: Some TODO items. X-Git-Tag: RELEASE_1_2~254 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=9e07b59f9cd546412fc4889a3851b57532c1aa0e;p=php Some TODO items. --- diff --git a/ext/unicode/unicode_iterators.c b/ext/unicode/unicode_iterators.c index 6c79efc4dd..8c20c072a1 100644 --- a/ext/unicode/unicode_iterators.c +++ b/ext/unicode/unicode_iterators.c @@ -22,6 +22,7 @@ * - optimize current() to pass return_value to the handler so that it fills it * in directly instead of creating a new zval * - return code units as binary strings? integers? or leave as unicode strings? + * - implement Countable (or count_elements handler) and Seekable interfaces */ #include "php.h" @@ -43,8 +44,8 @@ typedef struct { zval* current; union { struct { - int32_t offset; int32_t index; + int32_t offset; } cp; struct { int32_t index;